Skip to content

Detect when the package is installed globally #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 30, 2020

Conversation

mveyrenc
Copy link

This merge request makes this composer command works when it is install in global and not in the project.

Copy link
Owner

@Elendev Elendev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mveyrenc, thanks for your PR!
Sorry for the delay, it's a complicated time 😅

Can you revert all the code formatting that has been modified on the whole file?
I prefer to have consistency between all the files of the project.

For the rest, I'm not able to test it, but I'll gladly merge it, it's an elegant way to handle this issue.

Thanks!

@mveyrenc mveyrenc force-pushed the detect-global-install branch from fc1e123 to 37c61fb Compare April 28, 2020 15:30
@mveyrenc
Copy link
Author

Hi, I revert all the code formatting.

Don't hesitate to come back to me if you get any more feedback.

We use your plugin by install it in global, to avoid to add its dependencies to the project; Like this :

composer global require --dev elendev/nexus-composer-push
composer nexus-push ...

Thanks!

@Elendev
Copy link
Owner

Elendev commented Apr 30, 2020

@mveyrenc are you sure you pushed your commit? I only see one commit, and the formatting is still there.
As soon as it's done I'll merge it.
Thanks!

@mveyrenc mveyrenc force-pushed the detect-global-install branch from 37c61fb to 4f5b6c9 Compare April 30, 2020 14:00
@mveyrenc
Copy link
Author

Sorry my IDE format code before commit, this time it's OK.

@Elendev
Copy link
Owner

Elendev commented Apr 30, 2020

Thanks!

@Elendev Elendev merged commit 4d8504c into Elendev:master Apr 30, 2020
@Elendev Elendev mentioned this pull request May 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants