Skip to content

Update woocommerce-gateway-lightning.php more helpfull error message #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

renepickhardt
Copy link

made the error message if php-curl or php-gd are missing more explicit for inexperienced users by extenting the patch provided in ca40a13
from issue: #10

made the error message if php-curl or php-gd are missing more explicit for inexperienced users
@shesek
Copy link
Contributor

shesek commented Jan 27, 2018

Thanks for the contribution, but I think the existing error message is clear enough and not sure this is worth the extra code. Should be easy enough to figure out which one is missing once you know that one of them are.

removed the case distinction about which plugin is missing. however I think the note for people running the plugin in managed hosting settings is still usefull
@renepickhardt
Copy link
Author

I removed the else statements. However I think particularly for inexperienced coders the hint that on a shared hosting plan (which many wordpress users are using) it might be a problem is helpful.

@shesek
Copy link
Contributor

shesek commented Jan 27, 2018

I think a message like that is too specific. This isn't necessarily running on apache (could be running on a different http server, like nginx), and php-gd/php-curl support are quite common in shared hosting environments, so suggesting users to move away might be too extreme (a quick email to the technical support of their hosting provider might be able to solve that without switching servers).

made the error message more general
@renepickhardt
Copy link
Author

I changed the message once more. I am sure it'll be my last commit on this pull request (:

@shesek
Copy link
Contributor

shesek commented Jan 28, 2018

I added this separately in 0f0ffa8, with a less verbose message and because this PR has 3 separate commits. Thanks Rene!

@renepickhardt
Copy link
Author

perfect thanks (: btw just setting up my lnd node. I probably fork your wp-woocommerce-gateway-lightning to a wp-woocommerce-gateway-lnd.

@shesek
Copy link
Contributor

shesek commented Jan 28, 2018

Very cool! Would be great to have an lnd version of this. Good luck.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants