fix: peersync - case insensitive asset parsing#437
Merged
YusukeShimizu merged 1 commit intoMay 14, 2026
Merged
Conversation
YusukeShimizu
approved these changes
May 14, 2026
Contributor
YusukeShimizu
left a comment
There was a problem hiding this comment.
Approved. Thanks for the focused fix.
I also checked the previous misc_2 CI failure.
It was an unrelated integration-test/glightning shutdown race, and the rerun is green now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Related to #435
Nodes running the
peersync-based daemon (post-v5.0.0) silently drop all inbound poll messages from peers still on v5.0.0, causing a one-way compatibility break.NewAsset()performs a direct map lookup againststringToAsset, which only contains uppercase keys ("BTC","LBTC"). v5.0.0 nodes advertise assets in lowercase in their poll payloads. The lookup fails, the poll is discarded, andobservedAtnever refreshes on the remote side. The remote peer ages the node off their active list within hours and cannot recover without restarting their daemon.Logs on the node show:
Fix
Normalize the input with
strings.ToUpperbefore lookup so both uppercase and lowercase symbols are accepted.Testing
Verified manually against a v5.0.0 peer. Poll messages containing lowercase
"btc"/"lbtc"are now parsed correctly andobservedAtstays current.