Repository navigation
Conversation
The PyPI build job calls `make update-pyln-versions` on a fresh checkout, so config.vars is missing and $(SED) is empty. The recipe lines then start with `-i.bak`, which make reads as the ignore-errors prefix: every version bump fails with "i.bak: command not found" and the job carries on with whatever versions are committed. Fall back to plain sed when configure hasn't set one.
pyln-grpc-proto was dropped from the PyPI jobs because its module lives in pyln/grpc rather than pyln/grpc-proto, which the generic update-pyln-version-% rule assumes. Give it its own version target and add it back to the build and publish matrices. Closes ElementsProject#7929
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7929.
Adds pyln-grpc-proto back to the PyPI build and publish matrices. Its module lives in
pyln/grpc, so it gets its ownupdate-pyln-version-grpc-prototarget.While testing I found the "Update pyln versions" step in pypi-build.yml has never actually done anything. The job doesn't run
./configure, so$(SED)is empty and make reads the leading-i.bakas its ignore-errors prefix. The step passes but leaves the committed versions untouched. The first commit falls back to plainsed.Tested on a clean checkout without configure:
make update-pyln-versions NEW_VERSION=v26.09.1now bumps all four packages. Before, it printedi.bak: command not found ... (ignored)and changed nothing.uv build --package pyln-grpc-protobuildspyln_grpc_proto-26.9.1, with the generated protos included.For the release side:
PYPI_API_TOKENneeds upload rights on pyln-grpc-proto. The last release there is 24.2.1.#8999 was for the same issue but hasn't answered the August ping, and it still targets the old
pypi.yml.Changelog-None
Checklist
tools/lightning-downgrade