Repository navigation
wallet: preserve released migration indices - #9613
Open
vincenzopalazzo wants to merge 1 commit into
Open
vincenzopalazzo wants to merge 1 commit into
vincenzopalazzo wants to merge 1 commit into
Conversation
vincenzopalazzo
force-pushed
the
fix/issue-9608-db-migration
branch
3 times, most recently
from
October 8, 2026 20:14
905f324 to
ed32907
Compare
v26.06.8 shipped the funding feerate repairs as migrations 283 and 284. New wallet migrations were later inserted before them, so a node upgrading from that release started at 285, skipped the new wallet tables, and failed while backfilling them. Keep the released migration prefix immutable by restoring the feerate repairs to 283 and 284. Add test_v26_06_8_migrate at the released version-284 boundary so later migrations cannot move ahead of it again. Recreate the pre-repair schema in the existing feerate migration test so later non-idempotent migrations can run from their proper boundaries. Changelog-Fixed: wallet: upgrading from v26.06.8 no longer fails while backfilling the new wallet tables. Fixes: ElementsProject#9608 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
vincenzopalazzo
force-pushed
the
fix/issue-9608-db-migration
branch
from
October 8, 2026 23:11
ed32907 to
6767053
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
masterinserted the newour_outputs/our_txsmigrations before them, so an upgrade from v26.06.8 starts at migration 285, skips the table creation, and then fails inmigrate_backfill_bwatch_tableswithno such table: our_outputs. Fixes Database migration broken during migration to master #9608.test_v26_06_8_migrate, which recreates the released version-284 boundary and upgrades it to the current schema.Test plan
gmake -j4 PYTHON=.venv/bin/python./wallet/test/run-dbpytest -vv tests/test_splicing.py::test_splice_stored_feerate_repaired_on_upgrade(4 cases)test_v26_06_8_migrateaborts with the originalmasterordering and passes with this fixpytest -vv tests/test_askrene.py::test_reserve(isolated retry after its unrelated parallel-suite regex failure)