Repository navigation
Conversation
After 476aca4 "lightningd: don't broadcast a locked splice's stale commitment on force close" the value of the flag splice_locked_memonly is always false leading to dead code. Remove all the unused logic. Changelog-None Signed-off-by: Lagrang3 <lagrang3@protonmail.com>
Collaborator
|
This approach (just deleting it) will not work. The issue is a race condition in the event infrastructure. A correct solution would either refactor the entire event infrastructure to prevent the race condition. Another approach might be to separate inflights out of the normal event structure entirely, implementing the necessary event code from scratch for this particular need. Other approaches might work as well but these two 'correct' solutions are quite large / difficult / error prone for vital code which is why the Just deleting |
Collaborator
Author
|
@ddustin you have better insight into this than me. Feel free to propose a better approach. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After 476aca4
"lightningd: don't broadcast a locked splice's stale commitment on force close" the value of the flag splice_locked_memonly is always false leading to dead code.
Remove all the unused logic.