Repository navigation
tests: wait for announcements in test_splice_rbf_htlc_sigs - #9611
Open
daywalker90 wants to merge 1 commit into
Open
daywalker90 wants to merge 1 commit into
daywalker90 wants to merge 1 commit into
Conversation
The splice changes the channel's short_channel_id. If the test does not wait for the channel to be announced first, a node can receive a node_announcement for a peer before the channel_announcement for the new scid. gossipd then logs "Bad gossip order: node_announcement: unknown node", and the teardown check fails the test even though its body passes. Wait for announcements before splicing, as the other splice tests do. Changelog-None
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The splice changes the channel's short_channel_id. If the test does not wait for the channel to be announced first, a node can receive a node_announcement for a peer before the channel_announcement for the new scid. gossipd then logs "Bad gossip order: node_announcement: unknown node", and the teardown check fails the test even though its body passes.
Wait for announcements before splicing, as the other splice tests do.
Changelog-None
Fixes CI flake: