fuzz-tests: improve fuzz-channel_id
#8386
Open
+8
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
June 13, 2025 11:50
Changelog-None: `memcmp()` the output of `towire_channel_id()` and the input to `fromwire_channel_id()` to ensure that wire encoding-decoding is correctly performed.
Replace instances of 36 with sizeof(outpoint) and 32 with sizeof(chan_id) since that's what they represent. This makes the test more future-proof.
Improvements in the fuzz-testing scheme of `fuzz-channel_id led to the discovery of test inputs that result in greater in code coverage. Add these inputs to the test's seed corpus.
morehouse
approved these changes
Jun 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a couple of improvements to the fuzz test
tests/fuzz/fuzz-channel_id. Commit the newly discovered seed corpus inputs as well.Checklist
Before submitting the PR, ensure the following tasks are completed. If an item is not applicable to your PR, please mark it as checked:
CC: @morehouse