Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Offers initial cleanups #5633

Merged
merged 9 commits into from
Sep 29, 2022
Merged

Offers initial cleanups #5633

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
8b62249
lightningd: have `makesecret` take `hex` or `string` (just like `data…
rustyrussell Sep 29, 2022
f7468a2
doc: update references to old BOLTs repo.
rustyrussell Sep 29, 2022
013326d
onionmessages: remove obsolete onion message parsing.
rustyrussell Sep 29, 2022
3f64fda
plugins/fetchinvoice: remove obsolete string-based API.
rustyrussell Sep 29, 2022
33d3576
devtools: enhance bolt12-cli to convert to/from hex
rustyrussell Sep 29, 2022
58f5b59
pytest: test that we don't change our payer_key calculation.
rustyrussell Sep 29, 2022
a3017c2
bitcoin: add routine to check a Schnorr sig given a 33-byte pubkey.
rustyrussell Sep 29, 2022
9cd2520
common/onion: remove old blinded payment handling.
rustyrussell Sep 29, 2022
b19fd13
channeld: remove onion objects.
rustyrussell Sep 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
channeld: remove onion objects. 
We don't actually process onion messages here any more (they moved to
connectd), but the flag and object files were still linked.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
  • Loading branch information
@rustyrussell
rustyrussell committed Sep 29, 2022
commit b19fd13ddb28808bc5cbfdb9e26812a980e031c9
2 changes: 0 additions & 2 deletions channeld/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,6 @@ CHANNELD_COMMON_OBJS := \
common/memleak.o \
common/msg_queue.o \
common/node_id.o \
common/onion.o \
common/onionreply.o \
common/peer_billboard.o \
common/peer_failed.o \
Expand All @@ -78,7 +77,6 @@ CHANNELD_COMMON_OBJS := \
common/pseudorand.o \
common/read_peer_msg.o \
common/setup.o \
common/sphinx.o \
common/status.o \
common/status_wire.o \
common/subdaemon.o \
Expand Down
4 changes: 0 additions & 4 deletions channeld/channeld.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3802,9 +3802,6 @@ static void init_channel(struct peer *peer)
struct channel_type *channel_type;
u32 *dev_disable_commit; /* Always NULL */
bool dev_fast_gossip;
#if !DEVELOPER
bool dev_fail_process_onionpacket; /* Ignored */
#endif

assert(!(fcntl(MASTER_FD, F_GETFL) & O_NONBLOCK));

Expand Down Expand Up @@ -3867,7 +3864,6 @@ static void init_channel(struct peer *peer)
&remote_ann_bitcoin_sig,
&channel_type,
&dev_fast_gossip,
&dev_fail_process_onionpacket,
&dev_disable_commit,
&pbases,
&reestablish_only,
Expand Down
1 change: 0 additions & 1 deletion channeld/channeld_wire.csv
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,6 @@ msgdata,channeld_init,remote_ann_node_sig,?secp256k1_ecdsa_signature,
msgdata,channeld_init,remote_ann_bitcoin_sig,?secp256k1_ecdsa_signature,
msgdata,channeld_init,desired_type,channel_type,
msgdata,channeld_init,dev_fast_gossip,bool,
msgdata,channeld_init,dev_fail_process_onionpacket,bool,
msgdata,channeld_init,dev_disable_commit,?u32,
msgdata,channeld_init,num_penalty_bases,u32,
msgdata,channeld_init,pbases,penalty_base,num_penalty_bases
Expand Down
1 change: 0 additions & 1 deletion lightningd/channel_control.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -783,7 +783,6 @@ bool peer_start_channeld(struct channel *channel,
remote_ann_bitcoin_sig,
channel->type,
IFDEV(ld->dev_fast_gossip, false),
IFDEV(dev_fail_process_onionpacket, false),
IFDEV(ld->dev_disable_commit == -1
? NULL
: (u32 *)&ld->dev_disable_commit,
Expand Down