Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated things for next release #4902

Merged
merged 12 commits into from
Nov 14, 2021
Merged
Prev Previous commit
Next Next commit
pytest: don't create 5 nodes in test_fetchinvoice.
CI seems to be OOM killing us; 5 may be too many under valgrind.

VALGRIND=1 pytest tests/test_pay.py::test_fetchinvoice 
Before:
	1 passed in 199.33s (0:03:19)

After:
	1 passed in 177.91s (0:02:57)

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
  • Loading branch information
rustyrussell committed Nov 12, 2021
commit 02f3cecdacfa470db7c8f7432f8aed6b5d2d5547
6 changes: 1 addition & 5 deletions tests/test_pay.py
Original file line number Diff line number Diff line change
Expand Up @@ -4499,7 +4499,7 @@ def test_fetchinvoice(node_factory, bitcoind):
'recurrence_label': 'test recurrence'})

# Check we can request invoice without a channel.
l4, l5 = node_factory.get_nodes(2, opts={'experimental-offers': None})
l4 = node_factory.get_node(options={'experimental-offers': None})
l4.rpc.connect(l2.info['id'], 'localhost', l2.port)
# ... even if we can't find ourselves.
l4.rpc.call('fetchinvoice', {'offer': offer3['bolt12'],
Expand All @@ -4510,10 +4510,6 @@ def test_fetchinvoice(node_factory, bitcoind):
l4.rpc.connect(l3.info['id'], 'localhost', l3.port)
l4.rpc.call('fetchinvoice', {'offer': offer1['bolt12']})

# ... even if we are also in gossmap.
node_factory.join_nodes([l3, l5], wait_for_announce=True)
l4.rpc.call('fetchinvoice', {'offer': offer1['bolt12']})

# Now, test amount in different currency!
plugin = os.path.join(os.path.dirname(__file__), 'plugins/currencyUSDAUD5000.py')
l3.rpc.plugin_start(plugin)
Expand Down