Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hsm_encryption: read from STDIN if not in a TTY #4571

Merged
merged 4 commits into from
Jun 3, 2021
Merged

hsm_encryption: read from STDIN if not in a TTY #4571

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4c82545
hsm_encryption: read from STDIN if not in a TTY
openoms Jun 1, 2021
8e86a57
lightningd: remove duplicate temp term creation
openoms Jun 1, 2021
07269b0
hsm_encryption.c: remove whitespace from line end
openoms Jun 3, 2021
cf5eabc
hsm_encryption.c: fix source include order
openoms Jun 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
lightningd: remove duplicate temp term creation
  • Loading branch information
@openoms
openoms committed Jun 1, 2021
commit 8e86a57824107c11913490f84e78c9ea8c4f766b
8 changes: 0 additions & 8 deletions lightningd/options.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -390,16 +390,8 @@ static char *opt_important_plugin(const char *arg, struct lightningd *ld)
*/
static char *opt_set_hsm_password(struct lightningd *ld)
{
struct termios current_term, temp_term;
char *passwd, *passwd_confirmation, *err;

/* Get the password from stdin, but don't echo it. */
if (tcgetattr(fileno(stdin), &current_term) != 0)
return "Could not get current terminal options.";
temp_term = current_term;
temp_term.c_lflag &= ~ECHO;
if (tcsetattr(fileno(stdin), TCSAFLUSH, &temp_term) != 0)
return "Could not disable password echoing.";
printf("The hsm_secret is encrypted with a password. In order to "
"decrypt it and start the node you must provide the password.\n");
printf("Enter hsm_secret password:\n");
Expand Down