Fix installing plugins in dockerfile #2451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
March 5, 2019 12:14
- All files generated by 'make install' are copied - Fixes issues with incomplete installation. - Example: New executables created by build but are missing in docker.
|
Concept ACK. Will test it. |
|
|
|
The error above seems unrelated to this PR. |
|
For me to test this PR we need to fix first the version mismatch issue. ( |
|
So the problem came from my docker cache being old. That said, if I do enable-static, I can fix it for all... resuming my test for this PR. |
|
Tested ACK. |
|
Thanks! |
|
ACK 24a5065 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current state
In docker, the lightning installation is achieved by copying binaries one by one ‘manually’. As soon as a new binary is added, the dockerfile become outdated. See #2377
What has been done
Binaries are installed into a temporary directory using
configure --prefix=andmake install, then the installation directory is copied ‘as-it-is’ to the final image in the second phase of the build. This will guarantee that any new lib/binary/plugin generated frommake installwill be reflected in the docker images, and more important, the docker image configuration is closer to the normal build.Note to the maintainers
Update the official docker image after the merge of this PR.