Skip to content

In Debian at least, the Python 3 version of pytest is called pytest-3. #1544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

bitonic-cjp
Copy link
Contributor

Use this executable name to make sure we don't try to use the Python 2 version.

…. Use this executable name to make sure we don't try to use the Python 2 version.
@cdecker
Copy link
Member

cdecker commented Jun 5, 2018

NACK

This breaks the build for people that use pip3 to install pytest. This is really debian/ubuntu's fault for renaming the scripts.

@bitonic-cjp
Copy link
Contributor Author

Is a different approach possible? Maybe make this name configurable? Maybe have pytest-3 as default, and automatically try pytest if pytest-3 doesn't exist? I'd prefer pytest-3 as default, since explicit (mentioning of Python version) is better than implicit.

How do other distributions deal with having both Python 2 and Python 3 versions of this program?

@cdecker
Copy link
Member

cdecker commented Jun 5, 2018

Given that this is probably highly platform specific I think it should be rolled into #1538 and select the correct executable from a list of known executables.

@bitonic-cjp
Copy link
Contributor Author

I agree with using #1538 as a solution.

@bitonic-cjp bitonic-cjp mentioned this pull request Jun 6, 2018
cdecker added a commit to cdecker/lightning that referenced this pull request Jun 8, 2018
Fixes ElementsProject#1544

Signed-off-by: Christian Decker <decker.christian@gmail.com>
@cdecker
Copy link
Member

cdecker commented Jun 8, 2018

@bitonic-cjp can you check that PR #1557 detects the pytest binary correctly? It'll go through a list of known aliases, the last ones being the original scripts names if installed from pip.

@cdecker cdecker closed this in 3cf1581 Jun 9, 2018
@bitonic-cjp
Copy link
Contributor Author

@cdecker it correctly detects pytest-3 on my system, even though (to make it difficult) the Python 2 pytest was also installed.

So, all OK; thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants