Support `option_anchors_zero_fee_htlc_tx` feature 22/23

[JssDWt]

Issue and Steps to Reproduce

There is an incompatibility between LND and CLN currently. LND is unable to open a zero conf anchor channel to a CLN node, because LND sets the required feature option_anchors_zero_fee_htlc_tx, which CLN does not support.

Steps to reproduce:

• Spin up an LND node with --protocol.zero-conf and --protocol.option-scid-alias
• Spin up a CLN node with a zero conf accepting plugin
• Open a channel from LND to CLN with commitmenttype anchors and zero conf
• Feature negotation will fail, because CLN does not support option_anchors_zero_fee_htlc_tx

Since this is an interoperability issue, here's the issue in the LND repository: lightningnetwork/lnd#7230

[chrisguida]

Closed by #6334 i think.
I'm a bit confused though, what do zero conf channels have to do with option_anchors_zero_fee_htlc_tx?

[JssDWt]

I'm a bit confused though, what do zero conf channels have to do with option_anchors_zero_fee_htlc_tx?

Nothing from CLN's perspective.
LND only allows opening zero conf channels with anchors. And anchors in LND have zero fee htlc tx.
So it was not possible to open zero conf channels from LND to CLN. #6334 should fix this issue, yes.

[chrisguida]

Gotcha, thanks!

Maybe give it a test and then we can call this complete?

[JssDWt]

Maybe give it a test and then we can call this complete?

Currently getting You gave bad parameters: Did not support channel_type 12,22,50 when opening a zero conf channel from LND to CLN.

I guess the combination zero fee htlc tx + zero conf could be missing?

[chrisguida]

Did you enable experimental-anchors in your config?

[JssDWt]

Did you enable experimental-anchors in your config?

Yes

[chrisguida]

Hmm ok. I got nothing then, maybe you were right about this:

I guess the combination zero fee htlc tx + zero conf could be missing?

[JssDWt]

Hmm ok. I got nothing then, maybe you were right about this:

Yeah I think so. @cdecker said "It's likely just an entry in the default channel type table missing."

[chrisguida]

Is "You gave bad parameters: Did not support channel_type 12,22,50" an LND error or a CLN error?

Have you decoded your features hex string using ./devtools/features <hex>?

[cdecker]

So my initial comment seems to not apply, the table is not written out completely, rather we consider variants of the default types:

lightning/common/channel_type.c

Lines 165 to 168 in c67f1f9

	static const size_t variants[] = {
	OPT_SCID_ALIAS,
	OPT_ZEROCONF,
	};

This code accepts the channel_type by blanking optional features and then checking for equality to one of our default variants.

The error originates from CLN:

lightning/openingd/openingd.c

Line 138 in c67f1f9

"You gave bad parameters: %s", errmsg);

lightning/openingd/dualopend.c

Line 414 in c67f1f9

open_abort(state, "You gave bad parameters: %s", errmsg);

wrapping the inner error at

lightning/openingd/openingd.c

Line 976 in c67f1f9

"Did not support channel_type %s",

lightning/openingd/dualopend.c

Line 2266 in c67f1f9

"Did not support channel_type %s",

I wonder if we could build a repro test between CLN and CLN with this combination, because that should be the zeroconf variant we get when turning both of them on, right?

[cdecker]

Assigning myself as well in order to hunt down the zeroconf + zeroanchor failure.