Skip to content

libsecp256k1_recovery.h missing #4229

Closed
@jsarenik

Description

@jsarenik

Issue and Steps to Reproduce

See #4028 (comment)

Worth noting is that even when the error shows and part of compilation is terminated, make waits for the rest, the rest seemingly finishes, but the return value is 2:

# Put repo in clean state (like if it was virgin-cloned)
~/src/lightning$ { git submodule deinit --all --force; git clean -xffd; } >/dev/null 2>&1
~/src/lightning$ git describe
v0.9.2-23-g70977a4fb
~/src/lightning$ ./configure && make -j4 && make PREFIX=$HOME/lightning-my install ### let it finish
...
~/src/lightning$ echo $?
2

This is pretty bad for scripting. In other words the make install part was not run at all because make -j4 ended with 2. But also the compilation is not finished really (just checked lightningd/lightningd is missing).

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions