Sighash support for BIP341/342/118 #356
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
instagibbs
changed the title
instagibbs
force-pushed
the
basic_taproot_support
branch
from
30585fd
to
b036b4f
Compare
instagibbs
force-pushed
the
basic_taproot_support
branch
from
b036b4f
to
b576b4c
Compare
|
Hi @instagibbs thanks for this! Will need a little tweaking for merging, I've merged the first commit to #351 and will work on the others as time permits. Leaving this open to track. |
|
Good stuff, let me know whatever is needed |
|
@instagibbs as discussed offline, I've pushed the reworked commits to #351 if you'd like to review there (or offline). Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has received some light testing as part of my work on eltoo in CLN. Should be very simple to add the actual signature support on top, which I've done in my local CLN repo in a few lines.
Partially resolves #304
cc @greenaddress