Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring Elements up to date with Bitcoin Core 0.21 #935

Merged
merged 9,112 commits into from
Apr 6, 2021
This pull request is big! We’re only showing the most recent 250 commits.

Commits on Nov 29, 2020

  1. Configuration menu
    Copy the full SHA
    e623803 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    510dbdf View commit details
    Browse the repository at this point in the history
  3. Merge 62e3eb9 into merged_master (Bitcoin PR #19241)

    This caused a segfault because we have no checkpoints. Added a NULL check
    which jnewbery suggested on the original PR, but for some reason didn't
    get in.
    apoelstra committed Nov 29, 2020
    Configuration menu
    Copy the full SHA
    3a620fb View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    28f22e3 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    b2cc574 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    42ec9ec View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    a7602fb View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    28c2a09 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    81a3dda View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    8804910 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    0a093f7 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    a1b43a0 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    ca42c61 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    592ecdc View commit details
    Browse the repository at this point in the history
  15. Merge 8c5f681 into merged_master (Bitcoin PR #18267)

    This commit adds signet support, which is a little bit silly/redundant for us :)
    Was a surprisingly easy merge to handle, and hopefully in future Core is more
    mindful of signed blocks when they are changing code architecture.
    
    I had to change a couple lines of src/signet.cpp to add blank assets to the
    CTxOuts and to find transaction input scriptWitnesses. No need to add any
    other tx witness data (and the CAsset()s that I did add to make things compile
    won't be used..) because signet will always have g_con_elementsmode off.
    apoelstra committed Nov 29, 2020
    Configuration menu
    Copy the full SHA
    455f61c View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    1c0f4b7 View commit details
    Browse the repository at this point in the history
  17. Merge d692d19 into merged_master (Bitcoin PR #19849)

    More RPC cleanups. This one discovered that the `createpsbt` and
    `rawblindrawtransaction` RPCs had incorrect argument lists :)
    apoelstra committed Nov 29, 2020
    Configuration menu
    Copy the full SHA
    5c1a330 View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    f9355de View commit details
    Browse the repository at this point in the history
  19. Configuration menu
    Copy the full SHA
    b260d5c View commit details
    Browse the repository at this point in the history
  20. Configuration menu
    Copy the full SHA
    7892a18 View commit details
    Browse the repository at this point in the history
  21. Configuration menu
    Copy the full SHA
    c1f937f View commit details
    Browse the repository at this point in the history
  22. Configuration menu
    Copy the full SHA
    7a8f77d View commit details
    Browse the repository at this point in the history
  23. Configuration menu
    Copy the full SHA
    a34b91c View commit details
    Browse the repository at this point in the history
  24. Merge 5e14faf into merged_master (Bitcoin PR #19994)

    We have a couple RPC hacks in src/wallet/rpcwallet.cpp that were a bit annoying
    to adapt, but nothing too bad.
    
    Found a misspelling of `ignoreblindfail` in the `sendtoaddress` args, and a
    discrepancy in the `createrawpegin`/`createpegin` args
    apoelstra committed Nov 29, 2020
    Configuration menu
    Copy the full SHA
    915a1a4 View commit details
    Browse the repository at this point in the history
  25. Configuration menu
    Copy the full SHA
    029320f View commit details
    Browse the repository at this point in the history
  26. Configuration menu
    Copy the full SHA
    5f5f427 View commit details
    Browse the repository at this point in the history
  27. Configuration menu
    Copy the full SHA
    52c2d8e View commit details
    Browse the repository at this point in the history
  28. Configuration menu
    Copy the full SHA
    614dbd2 View commit details
    Browse the repository at this point in the history
  29. Configuration menu
    Copy the full SHA
    65b0132 View commit details
    Browse the repository at this point in the history
  30. Configuration menu
    Copy the full SHA
    6753184 View commit details
    Browse the repository at this point in the history
  31. Configuration menu
    Copy the full SHA
    62ec516 View commit details
    Browse the repository at this point in the history
  32. Configuration menu
    Copy the full SHA
    07d50b2 View commit details
    Browse the repository at this point in the history
  33. Configuration menu
    Copy the full SHA
    d105732 View commit details
    Browse the repository at this point in the history
  34. Configuration menu
    Copy the full SHA
    e20126c View commit details
    Browse the repository at this point in the history
  35. Configuration menu
    Copy the full SHA
    850b0e3 View commit details
    Browse the repository at this point in the history
  36. Configuration menu
    Copy the full SHA
    1f47015 View commit details
    Browse the repository at this point in the history
  37. Configuration menu
    Copy the full SHA
    1da43aa View commit details
    Browse the repository at this point in the history
  38. Configuration menu
    Copy the full SHA
    3a833cd View commit details
    Browse the repository at this point in the history
  39. Configuration menu
    Copy the full SHA
    7c68cb4 View commit details
    Browse the repository at this point in the history

Commits on Nov 30, 2020

  1. Configuration menu
    Copy the full SHA
    61e0475 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5a731b1 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    64bfdd9 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    c364bce View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    6356801 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    b64dffc View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    2d56dfb View commit details
    Browse the repository at this point in the history
  8. Merge 1769828 into merged_master (Bitcoin PR #19501)

    Adds "verbose" flag to a bunch of RPC that pass through to SendMoney. I also
    added it to sendtomainchain and destroyamount.
    apoelstra committed Nov 30, 2020
    Configuration menu
    Copy the full SHA
    1b85209 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    e3853b4 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    369ebdd View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    33a0d5e View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    4b62325 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    fb606bb View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    86c430b View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    638acbc View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    e5875a7 View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    350d109 View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    6eb01f8 View commit details
    Browse the repository at this point in the history
  19. Configuration menu
    Copy the full SHA
    979fc8e View commit details
    Browse the repository at this point in the history
  20. Configuration menu
    Copy the full SHA
    f217787 View commit details
    Browse the repository at this point in the history
  21. Merge df2129a into merged_master (Bitcoin PR #19991)

    I had to make up an onion service target port for Liquid and for our custom
    params, so I chose 37041 and 37040 to roughly match how signet just adds
    30000 to its normal port.
    apoelstra committed Nov 30, 2020
    Configuration menu
    Copy the full SHA
    77c3300 View commit details
    Browse the repository at this point in the history
  22. Configuration menu
    Copy the full SHA
    dc097c6 View commit details
    Browse the repository at this point in the history
  23. Configuration menu
    Copy the full SHA
    8ef11db View commit details
    Browse the repository at this point in the history
  24. Configuration menu
    Copy the full SHA
    62faba7 View commit details
    Browse the repository at this point in the history
  25. Configuration menu
    Copy the full SHA
    1108aae View commit details
    Browse the repository at this point in the history
  26. Configuration menu
    Copy the full SHA
    0fd697a View commit details
    Browse the repository at this point in the history
  27. Configuration menu
    Copy the full SHA
    4285f7d View commit details
    Browse the repository at this point in the history
  28. Configuration menu
    Copy the full SHA
    05d14ea View commit details
    Browse the repository at this point in the history
  29. Configuration menu
    Copy the full SHA
    f1975b4 View commit details
    Browse the repository at this point in the history
  30. Configuration menu
    Copy the full SHA
    40ea75c View commit details
    Browse the repository at this point in the history
  31. Configuration menu
    Copy the full SHA
    a9a69ea View commit details
    Browse the repository at this point in the history
  32. Merge e620722 into merged_master (Elements PR ElementsProject#911)

    Spent a while figuring out where this new function should live now that
    the PSBT stuff has been pulled into src/psbt.cpp and the wallet, and isn't
    mixed up with the RPC logic.
    
    In the end I modified the the function to return a normal error rather
    than throwing an RPC exception and put it in src/psbt.cpp with the other
    functions that behave this way.
    apoelstra committed Nov 30, 2020
    Configuration menu
    Copy the full SHA
    0bc6dbb View commit details
    Browse the repository at this point in the history
  33. Merge 88067dd into merged_master (Elements PR ElementsProject#912)

    Also fixed an intermittent failure in feature_assetsdir.py that has
    been bugging me for the entire rebase.
    apoelstra committed Nov 30, 2020
    Configuration menu
    Copy the full SHA
    3ce8ed9 View commit details
    Browse the repository at this point in the history
  34. Configuration menu
    Copy the full SHA
    5275df6 View commit details
    Browse the repository at this point in the history
  35. Merge db88db4 into merged_master (Bitcoin PR #19339)

    Changes API for AcceptToMemoryPool to no longer check maximum fee; we remove
    this check from interfaces::CChain::testPeginClaimAcceptance. This is fine,
    the check never should have been there (this method's job is to notice double
    claim attempts and provide a more helpful message to the user; other mempool
    failures should be caught later in the `claimrawpegin` logic when we call
    `pwallet->commitTransaction` which actually subits to the mempool). It was
    only checking fees because the API made it easier to do so than to not.
    apoelstra committed Nov 30, 2020
    Configuration menu
    Copy the full SHA
    ab28355 View commit details
    Browse the repository at this point in the history
  36. Configuration menu
    Copy the full SHA
    43ebfe6 View commit details
    Browse the repository at this point in the history
  37. Configuration menu
    Copy the full SHA
    613f65d View commit details
    Browse the repository at this point in the history
  38. Configuration menu
    Copy the full SHA
    45f9d08 View commit details
    Browse the repository at this point in the history
  39. Configuration menu
    Copy the full SHA
    111d9d8 View commit details
    Browse the repository at this point in the history
  40. Configuration menu
    Copy the full SHA
    1961e9c View commit details
    Browse the repository at this point in the history
  41. Configuration menu
    Copy the full SHA
    6ded9c5 View commit details
    Browse the repository at this point in the history
  42. Configuration menu
    Copy the full SHA
    d3cbe23 View commit details
    Browse the repository at this point in the history
  43. Configuration menu
    Copy the full SHA
    d504893 View commit details
    Browse the repository at this point in the history
  44. Configuration menu
    Copy the full SHA
    4cb66aa View commit details
    Browse the repository at this point in the history
  45. Configuration menu
    Copy the full SHA
    c9621a0 View commit details
    Browse the repository at this point in the history
  46. Configuration menu
    Copy the full SHA
    a21f702 View commit details
    Browse the repository at this point in the history
  47. Configuration menu
    Copy the full SHA
    1c39630 View commit details
    Browse the repository at this point in the history
  48. Configuration menu
    Copy the full SHA
    c33f699 View commit details
    Browse the repository at this point in the history
  49. Configuration menu
    Copy the full SHA
    e40c695 View commit details
    Browse the repository at this point in the history
  50. Configuration menu
    Copy the full SHA
    ed77072 View commit details
    Browse the repository at this point in the history
  51. Configuration menu
    Copy the full SHA
    5ac09f4 View commit details
    Browse the repository at this point in the history
  52. Configuration menu
    Copy the full SHA
    6a979f9 View commit details
    Browse the repository at this point in the history
  53. Configuration menu
    Copy the full SHA
    a8f78d1 View commit details
    Browse the repository at this point in the history
  54. Configuration menu
    Copy the full SHA
    f327fa9 View commit details
    Browse the repository at this point in the history
  55. Configuration menu
    Copy the full SHA
    de9f306 View commit details
    Browse the repository at this point in the history
  56. Merge f2e6d14 into merged_master (Bitcoin PR #20147)

    Update secp256k1-zkp to ff4714e6417c56f7235b287d4a9e555df10e09af latest master,
    which is up to date with upstream libsecp 9e5939d2848df5508e3a6eb038273b28d255248c
    (pull request ElementsProject#835 Nov 4 2020)
    apoelstra committed Nov 30, 2020
    Configuration menu
    Copy the full SHA
    da0f4ad View commit details
    Browse the repository at this point in the history
  57. Configuration menu
    Copy the full SHA
    4eeadb7 View commit details
    Browse the repository at this point in the history

Commits on Dec 1, 2020

  1. Merge 3caee16 into merged_master (Bitcoin PR #19953)

    Taproot :D
    apoelstra committed Dec 1, 2020
    Configuration menu
    Copy the full SHA
    e765fc9 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    595bf70 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    ff121d0 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    653fe79 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    0ef3467 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    2a2f3e4 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    943ae42 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    7578d20 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    e483648 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    85663c7 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    205b628 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    b733f58 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    ebadde1 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    8930903 View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    ce4acf6 View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    2513610 View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    60ebf8a View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    f515eab View commit details
    Browse the repository at this point in the history
  19. Configuration menu
    Copy the full SHA
    3d291db View commit details
    Browse the repository at this point in the history
  20. Configuration menu
    Copy the full SHA
    5ca702b View commit details
    Browse the repository at this point in the history
  21. Configuration menu
    Copy the full SHA
    8606249 View commit details
    Browse the repository at this point in the history
  22. Configuration menu
    Copy the full SHA
    dad4175 View commit details
    Browse the repository at this point in the history
  23. Configuration menu
    Copy the full SHA
    8258a74 View commit details
    Browse the repository at this point in the history
  24. Configuration menu
    Copy the full SHA
    21a16c8 View commit details
    Browse the repository at this point in the history
  25. Configuration menu
    Copy the full SHA
    9eb2afd View commit details
    Browse the repository at this point in the history
  26. Configuration menu
    Copy the full SHA
    eebfc81 View commit details
    Browse the repository at this point in the history
  27. Configuration menu
    Copy the full SHA
    6f267e3 View commit details
    Browse the repository at this point in the history
  28. Configuration menu
    Copy the full SHA
    bd9d811 View commit details
    Browse the repository at this point in the history
  29. Configuration menu
    Copy the full SHA
    5a0577e View commit details
    Browse the repository at this point in the history
  30. Configuration menu
    Copy the full SHA
    f1188d7 View commit details
    Browse the repository at this point in the history
  31. Configuration menu
    Copy the full SHA
    797a5bf View commit details
    Browse the repository at this point in the history
  32. Configuration menu
    Copy the full SHA
    1254d10 View commit details
    Browse the repository at this point in the history
  33. Configuration menu
    Copy the full SHA
    7af2bdc View commit details
    Browse the repository at this point in the history
  34. Configuration menu
    Copy the full SHA
    fb9e54e View commit details
    Browse the repository at this point in the history
  35. Configuration menu
    Copy the full SHA
    6682a29 View commit details
    Browse the repository at this point in the history
  36. Configuration menu
    Copy the full SHA
    c257b0d View commit details
    Browse the repository at this point in the history
  37. Configuration menu
    Copy the full SHA
    d2c3e1a View commit details
    Browse the repository at this point in the history
  38. Configuration menu
    Copy the full SHA
    d80e17c View commit details
    Browse the repository at this point in the history
  39. Configuration menu
    Copy the full SHA
    f0eb108 View commit details
    Browse the repository at this point in the history
  40. Configuration menu
    Copy the full SHA
    10ea7f1 View commit details
    Browse the repository at this point in the history
  41. Configuration menu
    Copy the full SHA
    71593ae View commit details
    Browse the repository at this point in the history
  42. Configuration menu
    Copy the full SHA
    b1573fd View commit details
    Browse the repository at this point in the history
  43. Configuration menu
    Copy the full SHA
    ec01e32 View commit details
    Browse the repository at this point in the history
  44. Configuration menu
    Copy the full SHA
    11d75a5 View commit details
    Browse the repository at this point in the history
  45. Configuration menu
    Copy the full SHA
    3fde0f0 View commit details
    Browse the repository at this point in the history
  46. Configuration menu
    Copy the full SHA
    8c3388f View commit details
    Browse the repository at this point in the history
  47. Configuration menu
    Copy the full SHA
    f3afbf3 View commit details
    Browse the repository at this point in the history
  48. Configuration menu
    Copy the full SHA
    56bb454 View commit details
    Browse the repository at this point in the history
  49. Configuration menu
    Copy the full SHA
    d77603c View commit details
    Browse the repository at this point in the history
  50. Merge 8e9e190 into merged_master (Bitcoin PR #20257)

    Updates libsecp. A no-op since we just did this.
    apoelstra committed Dec 1, 2020
    Configuration menu
    Copy the full SHA
    2c9485f View commit details
    Browse the repository at this point in the history
  51. Configuration menu
    Copy the full SHA
    9ce2c21 View commit details
    Browse the repository at this point in the history
  52. Configuration menu
    Copy the full SHA
    02fc694 View commit details
    Browse the repository at this point in the history
  53. Configuration menu
    Copy the full SHA
    a01ffb9 View commit details
    Browse the repository at this point in the history
  54. Configuration menu
    Copy the full SHA
    b90d575 View commit details
    Browse the repository at this point in the history
  55. Configuration menu
    Copy the full SHA
    6a6ed8d View commit details
    Browse the repository at this point in the history
  56. Configuration menu
    Copy the full SHA
    7aa0fa1 View commit details
    Browse the repository at this point in the history
  57. Configuration menu
    Copy the full SHA
    aff3d05 View commit details
    Browse the repository at this point in the history
  58. Configuration menu
    Copy the full SHA
    c876734 View commit details
    Browse the repository at this point in the history

Commits on Dec 2, 2020

  1. Merge ef4c7c4 into merged_master (Bitcoin PR #18788)

    This one was pretty brutal, but ultimately nothing too surprising.
    Just had to keep track of which wallets owned which blinding keys,
    and in wallet_importprunedfunds.py I had to manually create a
    Liquid address.
    apoelstra committed Dec 2, 2020
    Configuration menu
    Copy the full SHA
    d009849 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0a4ca5b View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    0011948 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    1a2796e View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    31e4afc View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    ef2ff70 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    3f275df View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    2577c79 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    7643799 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    72793a9 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    105b7f1 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    b75d9aa View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    e565848 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    0b598c1 View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    699e2f4 View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    72b414f View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    db05bb0 View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    a209e89 View commit details
    Browse the repository at this point in the history
  19. Configuration menu
    Copy the full SHA
    31caf66 View commit details
    Browse the repository at this point in the history
  20. Configuration menu
    Copy the full SHA
    2afa482 View commit details
    Browse the repository at this point in the history
  21. Configuration menu
    Copy the full SHA
    23f0a22 View commit details
    Browse the repository at this point in the history
  22. Configuration menu
    Copy the full SHA
    c0c2c1e View commit details
    Browse the repository at this point in the history
  23. Configuration menu
    Copy the full SHA
    c387e34 View commit details
    Browse the repository at this point in the history
  24. Configuration menu
    Copy the full SHA
    6d63c29 View commit details
    Browse the repository at this point in the history
  25. Configuration menu
    Copy the full SHA
    f0ae078 View commit details
    Browse the repository at this point in the history
  26. Configuration menu
    Copy the full SHA
    2d1adac View commit details
    Browse the repository at this point in the history
  27. Configuration menu
    Copy the full SHA
    ed3ba32 View commit details
    Browse the repository at this point in the history
  28. Configuration menu
    Copy the full SHA
    51e3b53 View commit details
    Browse the repository at this point in the history
  29. Configuration menu
    Copy the full SHA
    3e49415 View commit details
    Browse the repository at this point in the history
  30. Configuration menu
    Copy the full SHA
    7ec1f12 View commit details
    Browse the repository at this point in the history
  31. Configuration menu
    Copy the full SHA
    c509a5d View commit details
    Browse the repository at this point in the history
  32. Configuration menu
    Copy the full SHA
    3f6fdc2 View commit details
    Browse the repository at this point in the history
  33. Configuration menu
    Copy the full SHA
    e9a3051 View commit details
    Browse the repository at this point in the history
  34. Configuration menu
    Copy the full SHA
    e8079c3 View commit details
    Browse the repository at this point in the history
  35. Configuration menu
    Copy the full SHA
    29abe91 View commit details
    Browse the repository at this point in the history
  36. Configuration menu
    Copy the full SHA
    e198740 View commit details
    Browse the repository at this point in the history
  37. Configuration menu
    Copy the full SHA
    45668b8 View commit details
    Browse the repository at this point in the history
  38. Configuration menu
    Copy the full SHA
    631d208 View commit details
    Browse the repository at this point in the history
  39. Configuration menu
    Copy the full SHA
    5928cc6 View commit details
    Browse the repository at this point in the history
  40. Configuration menu
    Copy the full SHA
    e4026fa View commit details
    Browse the repository at this point in the history
  41. Configuration menu
    Copy the full SHA
    af1c2e9 View commit details
    Browse the repository at this point in the history
  42. Configuration menu
    Copy the full SHA
    28c55d0 View commit details
    Browse the repository at this point in the history
  43. Configuration menu
    Copy the full SHA
    7036176 View commit details
    Browse the repository at this point in the history
  44. Configuration menu
    Copy the full SHA
    b5cddf1 View commit details
    Browse the repository at this point in the history
  45. Configuration menu
    Copy the full SHA
    870c0a9 View commit details
    Browse the repository at this point in the history
  46. Configuration menu
    Copy the full SHA
    ff7aedd View commit details
    Browse the repository at this point in the history
  47. Configuration menu
    Copy the full SHA
    81b13f5 View commit details
    Browse the repository at this point in the history
  48. Configuration menu
    Copy the full SHA
    fa64cc7 View commit details
    Browse the repository at this point in the history
  49. Configuration menu
    Copy the full SHA
    8659aaf View commit details
    Browse the repository at this point in the history
  50. Configuration menu
    Copy the full SHA
    1d5afb0 View commit details
    Browse the repository at this point in the history
  51. Configuration menu
    Copy the full SHA
    8712faa View commit details
    Browse the repository at this point in the history
  52. Configuration menu
    Copy the full SHA
    29c7f63 View commit details
    Browse the repository at this point in the history
  53. Configuration menu
    Copy the full SHA
    46e7d18 View commit details
    Browse the repository at this point in the history
  54. Configuration menu
    Copy the full SHA
    6a1fadf View commit details
    Browse the repository at this point in the history
  55. Configuration menu
    Copy the full SHA
    94f7b7b View commit details
    Browse the repository at this point in the history
  56. Configuration menu
    Copy the full SHA
    50dafec View commit details
    Browse the repository at this point in the history
  57. Configuration menu
    Copy the full SHA
    5b89a9f View commit details
    Browse the repository at this point in the history
  58. Configuration menu
    Copy the full SHA
    81e75ab View commit details
    Browse the repository at this point in the history

Commits on Mar 25, 2021

  1. Merge a993a7c into merged_master (Elements PR ElementsProject#960)

    Several conflicts in the C++ code related to the new `flags` parameter
    to `CheckSignature` and the corresponding function being renamed upstream
    to `CheckSignatureECDSA`.
    
    Several conflicts in the test harness as Steven sorta pulled the new
    upstream ECKey module into the Python code, and the actual upstream
    code was slightly different. Also needed to update the feature_taproot
    code to always use the non-RANGEPROOF sighash since dynafed is not
    enabled in the Taproot test.
    
    Also had to pull the `set_wif` method out of `ECKey` and inline it because
    otherwise it triggers a "circular inclusion" error between script.py (which
    would pull in `base58_to_bytes` from address.py) and address.py (which now
    pulls in some taproot EC related stuff from script.py).
    
    Noticed that ElementsProject#960 does not test the "sighash rangeproof flag set but no
    witnesses" case.
    apoelstra committed Mar 25, 2021
    Configuration menu
    Copy the full SHA
    22cf380 View commit details
    Browse the repository at this point in the history

Commits on Mar 26, 2021

  1. Merge 3b8e407 into merged_master (Elements PR ElementsProject#958)

    Conflicts due to change of error state formatting upstream.
    apoelstra committed Mar 26, 2021
    Configuration menu
    Copy the full SHA
    d891120 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    05e2213 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    59076ca View commit details
    Browse the repository at this point in the history
  4. Merge b9ee263 into merged_master (Elements PR ElementsProject#966)

    of course a one-line PR manages to conflict..
    apoelstra committed Mar 26, 2021
    Configuration menu
    Copy the full SHA
    0118851 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    48dc78d View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    0699c4d View commit details
    Browse the repository at this point in the history
  7. travis: temporarily blacklist a specific commit in the `scripted-diff…

    …` filter
    
    Commit f471a3b currently has the text "scripted diff"
    rather than "scripted-diff", which causes the scripted-diff linter to fail, saying
    that it sees a script but not the magic words.
    
    Changing the linter to detect "scripted diff" causes it to fail on this commit,
    because the included script does not work. (For reference, the script is
    
        r() { sed -i 's/vout must be positive/vout cannot be negative/g' $1 }
        r $(git grep -l 'vout must be positive')
    
    Bet you can't guess why bash rejects this without running it!)
    
    We should remember to change this back.
    apoelstra committed Mar 26, 2021
    Configuration menu
    Copy the full SHA
    ae06487 View commit details
    Browse the repository at this point in the history
  8. travis: temporarily disable lint-git-commit-check.sh

    This fails on upstream commit messages which are incorrectly formatted
    and there is obviously nothing we can do about this. Re-enable this
    check after the rebase is merged.
    apoelstra committed Mar 26, 2021
    Configuration menu
    Copy the full SHA
    29ab3fd View commit details
    Browse the repository at this point in the history
  9. fix RPC linter issues

    apoelstra committed Mar 26, 2021
    Configuration menu
    Copy the full SHA
    1e98c9f View commit details
    Browse the repository at this point in the history
  10. ci: various linter / CI compiler error fixes

    Includes changing TRUE to OP_TRUE for anyone-can-spend output name,
    to avoid symbol conflict on win64 builds, which is really obnoxious.
    apoelstra committed Mar 26, 2021
    Configuration menu
    Copy the full SHA
    68bfd70 View commit details
    Browse the repository at this point in the history
  11. ci: reduce secp test iterations from default 64 to 16

    The reduced secp iterations should prevent test timeouts on arm.
    Also reduce MAKEJOBS to avoid OOM/load failures in other jobs.
    apoelstra committed Mar 26, 2021
    Configuration menu
    Copy the full SHA
    79bab21 View commit details
    Browse the repository at this point in the history
  12. (temporarily?) delete Liquid gitian descriptors

    We should just reconstruct these from the Elements ones after the fact. They did
    not get updated throughout the rebase.
    apoelstra committed Mar 26, 2021
    Configuration menu
    Copy the full SHA
    848c597 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    f164228 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    db64bd5 View commit details
    Browse the repository at this point in the history
  15. ci: temporarily disable qa-assets unit tests

    These "pass" locally but in CI they download pre-signed transactions
    from https://github.com/bitcoin-core/qa-assets/ which we need to
    fork and recreate.
    
    Essentially these files are the output of the Taproot functional
    test (which passes), so I am not too worried about actual failures
    here. But we should wait until after the Taproot sighash is finalized
    to recreate these assets.
    apoelstra committed Mar 26, 2021
    Configuration menu
    Copy the full SHA
    ee5d4e3 View commit details
    Browse the repository at this point in the history
  16. build: drop the rendered icon stuff

    This is broken in multiple ways, does not exist in 0.14, appears in an
    unreviewed mega-PR "porting" from a version of liquid-qt that I cannot
    track down, and apparently has caused a fair bit of follow-on trouble
    with icon integration.
    
    Just put the icons in the repo like upstream does.
    
    The committed icons were built using the Makefile prior to this
    commit, starting from ./share/pixmaps/nsis-wizard.svg and
    ./src/qt/res/src/bitcoin.svg. They should be recreated manually
    if they need to be changed in the future.
    apoelstra committed Mar 26, 2021
    Configuration menu
    Copy the full SHA
    a1bac6d View commit details
    Browse the repository at this point in the history
  17. ci: eliminate a bunch of build warnings

    Includes removing some variables from qt/intro.cpp that've been
    unused since #13216 and ought to have been removed in the 0.17
    rebase, but our linters were not so agressive then. Similarly
    fix the BITCOIN_PID_FILE, whose value was incorrectly changed
    in the 0.18 rebase.
    apoelstra committed Mar 26, 2021
    Configuration menu
    Copy the full SHA
    2f5c624 View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    47885e9 View commit details
    Browse the repository at this point in the history
  19. Configuration menu
    Copy the full SHA
    0c98d2f View commit details
    Browse the repository at this point in the history
  20. ci: disable broken feature_pruning test

    It may be that we just need to recompute some numbers because our
    block limits are different. But this test takes 20 minutes to
    fail and it would take some time to understand what the expected
    behavior is.
    apoelstra committed Mar 26, 2021
    Configuration menu
    Copy the full SHA
    697cd77 View commit details
    Browse the repository at this point in the history
  21. ci: fix benchmarks, fuzztests and unit tests

    Includes a memory leak in the checkqueue unit test (but not in
    the actual code). WE really need to switch our checkqueue to use
    std::unique_pointer rather than bare pointers. But this would be
    invasive enough that I want to do it in a followup PR.
    
    Also pretty-much disable the validation_flush_cache unit test.
    This is a stupid and irritating test which tries to unit-test
    exact memory usage of std containers. It already has at least
    one "remove wrong assumptions" update upstream and after many
    tries I was unable to change all the magic numbers in a way
    that'd consistently pass CI for Elements.
    
    Also adds a couple ubsan suppressions about perfectly-legitimate
    conversions of integer types.
    apoelstra committed Mar 26, 2021
    Configuration menu
    Copy the full SHA
    1670bdf View commit details
    Browse the repository at this point in the history
  22. reduce cache sizes so that default maxsigcache size is same as Bitcoin

    Bitcoin allocates 32M for signature caching by default, split
    between a signature cache and a script validity cache (see
    Core #10192). Since 0.14 we have added an additional 32M for
    rangeproof caching *and* an additional 32M for surjectionproof
    caching.
    
    These cache entries cost a bit over 32 bytes, so these are room
    for a million entries....or 4Gb of rangeproofs and 300M of
    surjection proofs.
    
    Presumably we did not intend to triple memory usage relative to
    Core to deal with some champagne problem in which our mempool is
    overfilled ten times with pure rangeproofs. So put the total
    default cache size back to 32M. This should have no performance
    hit under realistic circumstances and should reduce CI OOM failures.
    
    On my system we now use 50M rather than 110M during the fedpeg
    test; we still use 18M that Core does not by having three additional
    global secp contexts (one in blind.cpp, one in pegins.cpp, one in
    confidential_validation.cpp) but we can settle that in a future
    commit.
    apoelstra committed Mar 26, 2021
    Configuration menu
    Copy the full SHA
    e5ecee8 View commit details
    Browse the repository at this point in the history
  23. Revert "gui: Alternate row background based on txid"

    This reverts commit 264f9c4d4f7c1aeb3e89eedddcd88e47e8bba938.
    
    This was included in ElementsProject#569
    which received no review, and is a backport of upstream PR
    bitcoin/bitcoin#12578 which was
    later closed. It leaks memory which is causing CI to fail.
    apoelstra committed Mar 26, 2021
    Configuration menu
    Copy the full SHA
    f912cb8 View commit details
    Browse the repository at this point in the history
  24. ci: correct bitcoin-node to elements-node for multiprocess CI job

    Also rename libbitcoin_consensus to libelements_consensus more
    consistently in src/Makefile.am. I'm not sure this was causing any
    problems but it did make it harder to follow what autotools is
    thinking.
    apoelstra committed Mar 26, 2021
    Configuration menu
    Copy the full SHA
    89926e6 View commit details
    Browse the repository at this point in the history
  25. test: disable "is everyone connected" check in sync_all in blocksigne…

    …r test
    
    Everyone is _not_ connected in this test, so on slow machines
    where this check triggers (e.g. the CI boxes) the test incorrectly
    fails. This was also a source of (very infrequent) spurious failures
    during the rebase.
    apoelstra committed Mar 26, 2021
    Configuration menu
    Copy the full SHA
    55be293 View commit details
    Browse the repository at this point in the history
  26. build: move dynafed and pak to server rather than libelementsconsensus

    This was causing build failures on win64, and since we (currently) do
    not expose any dynafed or PAK stuff in libelementsconsensus, there is
    no reason to be trying to link these.
    apoelstra committed Mar 26, 2021
    Configuration menu
    Copy the full SHA
    ef3bc30 View commit details
    Browse the repository at this point in the history
  27. disable previous-release compatibility test and walletupgrade test

    Should revisit; I am not sure whether we have a long-term stable
    URL for prebuilt past Elements releases, but we should be able
    to just point test/get-previous-releases.py at that, and change
    the set of versions (since we do not have 0.15, 0.19, etc), and
    we're good to go.
    apoelstra committed Mar 26, 2021
    Configuration menu
    Copy the full SHA
    f1092db View commit details
    Browse the repository at this point in the history
  28. Various ubsan fixes

    Mostly harmless signed/unsigned conversions but also an actual
    memory leak related to `BlindingData`.
    apoelstra committed Mar 26, 2021
    Configuration menu
    Copy the full SHA
    14ff891 View commit details
    Browse the repository at this point in the history
  29. Configuration menu
    Copy the full SHA
    98d0ff7 View commit details
    Browse the repository at this point in the history
  30. Configuration menu
    Copy the full SHA
    fec99ef View commit details
    Browse the repository at this point in the history
  31. Configuration menu
    Copy the full SHA
    1f068f8 View commit details
    Browse the repository at this point in the history
  32. Configuration menu
    Copy the full SHA
    e801e95 View commit details
    Browse the repository at this point in the history
  33. Configuration menu
    Copy the full SHA
    7575e05 View commit details
    Browse the repository at this point in the history

Commits on Mar 30, 2021

  1. Configuration menu
    Copy the full SHA
    f994740 View commit details
    Browse the repository at this point in the history

Commits on Mar 31, 2021

  1. ci: fix some test timeouts

    apoelstra committed Mar 31, 2021
    Configuration menu
    Copy the full SHA
    f76fe5e View commit details
    Browse the repository at this point in the history

Commits on Apr 1, 2021

  1. Configuration menu
    Copy the full SHA
    24ca09c View commit details
    Browse the repository at this point in the history

Commits on Apr 2, 2021

  1. Configuration menu
    Copy the full SHA
    291da8b View commit details
    Browse the repository at this point in the history