[HF] Dynafed blocks must have sighash byte#723
Merged
stevenroose merged 1 commit intoElementsProject:masterfrom Sep 29, 2019
Merged
[HF] Dynafed blocks must have sighash byte#723stevenroose merged 1 commit intoElementsProject:masterfrom
stevenroose merged 1 commit intoElementsProject:masterfrom
Conversation
instagibbs
changed the title
instagibbs
force-pushed
the
dynablock__sighash_byte
branch
2 times, most recently
from
7922bd4 to
491287b
Compare
stevenroose
suggested changes
Sep 27, 2019
instagibbs
force-pushed
the
dynablock__sighash_byte
branch
from
491287b to
29dbb59
Compare
It is not included in the signature hash. The sighash byte MUST be SIGHASH_ALL to avoid malleability.
instagibbs
force-pushed
the
dynablock__sighash_byte
branch
from
29dbb59 to
809f4ac
Compare
Contributor
|
ACK 809f4ac |
stevenroose
added a commit
that referenced
this pull request
Sep 29, 2019
809f4ac Dynafed blocks must have sighash byte (Gregory Sanders) Pull request description: It is not included in the signature hash. The sighash byte MUST be SIGHASH_ALL to avoid malleability. Tree-SHA512: d4a658448e3a8b3609b32fc24e8d28fc65ea13021ba0b49109b6c4477253d08183ac6e77e0658f23b2630cbb916c6b19e86db241c5d7456391385a308235d0bd
apoelstra
added a commit
to apoelstra/elements
that referenced
this pull request
Nov 6, 2020
apoelstra
added a commit
to apoelstra/elements
that referenced
this pull request
Nov 9, 2020
apoelstra
added a commit
to apoelstra/elements
that referenced
this pull request
Nov 10, 2020
stevenroose
pushed a commit
that referenced
this pull request
Mar 16, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is not included in the signature hash.
The sighash byte MUST be SIGHASH_ALL to avoid malleability.