[0.17] Default to elementsregtest, when syncing liquid, find cookie #520
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
instagibbs
changed the title
instagibbs
force-pushed
the
default_elementsregtest
branch
from
587f690 to
5c784ca
Compare
Contributor
Author
|
changing default is causing havok with some unit tests, investigating |
instagibbs
force-pushed
the
default_elementsregtest
branch
from
5c784ca to
40f80ef
Compare
30 tasks
instagibbs
commented
Mar 21, 2019
| boost::filesystem::path path(gArgs.GetArg("-mainchainrpccookiefile", MAINCHAIN_COOKIEAUTH_FILE)); | ||
| std::string cookie_file = MAINCHAIN_COOKIEAUTH_FILE; | ||
| // Bitcoin mainnet exception | ||
| if (gArgs.GetChainName() == "liquidv1") { |
Contributor
Author
There was a problem hiding this comment.
generalizing this becomes a pain due to dependencies :/
instagibbs
force-pushed
the
default_elementsregtest
branch
from
40f80ef to
5273ed5
Compare
Contributor
Author
|
rebased to catch mempool_packages.py fix |
Contributor
|
utACK 5273ed5 |
Contributor
|
This should also fix https://github.com/Blockstream/liquid/issues/26. |
instagibbs
added a commit
that referenced
this pull request
Mar 21, 2019
…ind cookie 5273ed5 Default to mainnet cookie for liquidv1 (Gregory Sanders) 8ea52ee Default to elementsregtest (Gregory Sanders) Pull request description: Cookie defaults looking in `regtest` directory currently. Tree-SHA512: df8e384f12c84e7adf86edcc2d4a96432187ce58b76f19ea347b911988f55177efebcd8f5a5986acfe19044535b27ad896ec3f75a273bae24826e33ba58f40e0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cookie defaults looking in
regtestdirectory currently.