[0.17] Signed blocks feature #478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll pull in Blockstream/liquid#8 too |
instagibbs
force-pushed
the
signed_block_squashed
branch
from
06b8373
to
dc2c553
Compare
|
Actually going to defer those to someone else's task, as they require rebase, and I'd rather let the original author do that :) |
30 tasks
instagibbs
force-pushed
the
signed_block_squashed
branch
from
dc2c553
to
ea70c20
Compare
|
rebased |
instagibbs
force-pushed
the
signed_block_squashed
branch
from
00bec9a
to
2d8137f
Compare
|
bitcoin_functional:wallet_listsinceblock.py failure. Can't reproduce locally and the logs aren't helpful in figuring out what was wrong. Restarting that job. |
stevenroose
previously requested changes
Dec 19, 2018
instagibbs
force-pushed
the
signed_block_squashed
branch
from
2d8137f
to
ede1538
Compare
|
Addressed comments |
instagibbs
force-pushed
the
signed_block_squashed
branch
from
ede1538
to
c5ab737
Compare
instagibbs
force-pushed
the
signed_block_squashed
branch
from
c5ab737
to
ebfc014
Compare
instagibbs
force-pushed
the
signed_block_squashed
branch
from
ebfc014
to
ff32b17
Compare
|
tACK ff32b17 |
stevenroose
added a commit
that referenced
this pull request
Dec 19, 2018
ff32b17 elements style genesis block commits to signblockscript in CommitToArguments (Gregory Sanders) 3169d38 added blocksign functional test (Gregory Sanders) d78f076 Signed blocks by default for custom chains (Gregory Sanders) 8723deb RPC support for signed blocks, compact blocks infrastructure (Gregory Sanders) 5877da8 Expose signed block information over RPC when active (Gregory Sanders) 0d7e0f9 Miner support for signed blocks (Gregory Sanders) 0e47322 Expose signed blocks in validation.cpp (Gregory Sanders) cd4e553 CProof (re)setting and validation helper functions (Gregory Sanders) 2a3dcde Set genesis block CProof to signblockscript if signed blocks active (Gregory Sanders) 6ad13bb Signed blocks have work of 1 each (Gregory Sanders) 6856beb Have chainstate store CProof for each block header (Gregory Sanders) 60f7062 Define block signatures, active IFF g_signed_blocks active (Gregory Sanders) f7c5cf7 Add not yet enforced chainparam arguments for signed blocks (Gregory Sanders) 7bc578a Add SimpleSignatureChecker, SCRIPT_NO_SIGHASH_BYTE validation flag (Gregory Sanders) 6c91446 Expose check_pow for compact blocks, helper to get available Tx list (Gregory Sanders) Pull request description: Squashed and rebased version of: #452 on my own repo. Adds `-con_signed_blocks` which enables signed block mode with `-signblockscript` defining the encumbrance, which replaces pow-based data in block headers with that script. `-con_max_block_sig_size` is a novel argument compared to `elements-0.14.1`, which caps the total size of the signature in the block header. This avoids all number of DoS concerns and simplifies the miner code. This also creates signed block RPCs, as well as compact block RPCs for blocksigner use. Tree-SHA512: af2624ff8d456673c40fba283f3cdbd2559b528b87ff9b10335f5fb893ff7d7b286655c9856bb23f84b5722c7ad0091e77208c89c18a6f71b1cbd18076841071
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Squashed and rebased version of: #452 on my own repo.
Adds
-con_signed_blockswhich enables signed block mode with-signblockscriptdefining the encumbrance, which replaces pow-based data in block headers with that script.-con_max_block_sig_sizeis a novel argument compared toelements-0.14.1, which caps the total size of the signature in the block header. This avoids all number of DoS concerns and simplifies the miner code.This also creates signed block RPCs, as well as compact block RPCs for blocksigner use.