[0.17] Add pegin validation #458

stevenroose · 2018-11-07T17:31:04Z

No description provided.

src/init.cpp

src/chainparams.cpp

src/primitives/transaction.h

stevenroose · 2018-11-26T17:50:12Z

Want to point out explicitly that I removed a check in AcceptToMempoolWorker in a9c0331.

It seems that that AcceptToMempoolWorker now calls CheckTxInputs while before it didn't do that. So that check seemed to be redundant there. I hope I'm not wrong about that.

instagibbs · 2018-11-26T17:53:01Z

That was something you had added, right?

stevenroose · 2018-11-27T11:20:11Z

@instagibbs yeah yeah of course. I added it by porting back, but then realized I added the check twice since it was also in CheckTxInputs. elements-0.14.1 has the pegin double-pegin-spend check separate: in CheckTxInputs for ConnectTip and separate independent for AcceptToMempoolWorker.

98a1846 tests: Support calling add_nodes more than once (Steven Roose) Pull request description: Ran into this while writing [a multi-chain test for Elements](ElementsProject/elements#458) where I call this method more than once. Tree-SHA512: f2d698fcb560552aa5d81a4c3fbf40b7269b228b34d85a118291649ef83f8c0a30cd82a28d418237b55893bcecd538046b704e64a4d8a41f2c0aef8033dc83e5

instagibbs · 2018-12-14T16:49:49Z

i poked the integration tests so I can see results outside of linter's complaints

instagibbs · 2018-12-14T16:55:05Z

pegins.cpp: In function ‘bool IsValidPeginWitness(const CScriptWitness&, const COutPoint&, bool)’:
pegins.cpp:317:37: warning: ‘num_txs’ may be used uninitialized in this function [-Wmaybe-uninitialized]
         if (!IsConfirmedBitcoinBlock(block_hash, Params().GetConsensus().pegin_min_depth, num_txs)) {
                                     ^
pegins.cpp:263:9: note: ‘num_txs’ was declared here
     int num_txs;

src/pegins.cpp

src/wallet/rpcwallet.cpp

instagibbs · 2018-12-14T17:12:31Z

src/wallet/rpcwallet.cpp

+    EnsureWalletIsUnlocked(pwallet);
+
+    mapValue_t mapValue;
+    CCoinControl no_coin_control; // This is a deprecated API


what part is deprecated?

Not sure. I mimicked existing code. I found the original comment was placed in ecd81df.

stevenroose · 2018-12-17T13:29:27Z

About that warning, that's because there is a signed block case that I commented out that is impossible to get into for now. It's gated behind bool ParentChainHasPow() const { return parent_chain_signblockscript == CScript();} that is always true.

Special validation added in next commits.

src/txdb.cpp

instagibbs · 2019-01-02T17:42:25Z

utACK aee6880

that intermittant test failure is really hard to trigger and is an important exception to force the user to restart important services anyways. I'm not going to let that be a blocker for merge.

instagibbs · 2019-01-02T17:44:13Z

re-utACK d358364

d358364 Integration test for pegins and pegouts (Steven Roose) d888540 Add support for signed-blocks parent chains (Steven Roose) b56f7da Add pegin and pegout RPC calls (Steven Roose) 7bb9380 Recognize pegout scripts (Steven Roose) 4688e3e Add periodic RPC recheck and invalid block recheck (Steven Roose) 0e4e834 Add pegin validation unit tests (Steven Roose) 5cbb014 Validation of pegin inputs (Steven Roose) f4adb46 Add spentness flag to pegin coins (Steven Roose) 0d07d21 Change CCoinsMapKey to use chain-aware outpoints (Steven Roose) 22ec499 Add "vdata" field to createrawtransaction rpc (Steven Roose) 2db1f2b Add tweakfedpegscript rpc (Steven Roose) d6686b6 Add getsidechaininfo rpc (Steven Roose) fb8a453 Add pegin validation utility methods (Steven Roose) 037b260 Serialize parent blocks without pegin flags (Steven Roose) 89613b8 Skip normal validation of pegin inputs (Steven Roose) ae54d4a Add pegin input serialization (Steven Roose) ac1eadd Add support for NullData addresses (OP_RETURN) (Steven Roose) 18ee341 Add parent address encoding (Steven Roose) d39d440 Add mainchain rpc client (Steven Roose) 238a72b Add arguments for parent chain characteristics (Steven Roose)

98a1846 tests: Support calling add_nodes more than once (Steven Roose) Pull request description: Ran into this while writing [a multi-chain test for Elements](ElementsProject/elements#458) where I call this method more than once. Tree-SHA512: f2d698fcb560552aa5d81a4c3fbf40b7269b228b34d85a118291649ef83f8c0a30cd82a28d418237b55893bcecd538046b704e64a4d8a41f2c0aef8033dc83e5

stevenroose changed the base branch from elements-0.14.1 to elements-0.17 November 7, 2018 17:31

stevenroose changed the title ~~[WIP; 0.17] Add pegin validation~~ [WIP, 0.17] Add pegin validation Nov 7, 2018

stevenroose force-pushed the e17-pegins branch from 957b8da to b2a2c3b Compare November 7, 2018 20:53

stevenroose mentioned this pull request Nov 7, 2018

Update elements to Bitcoin Core version 0.17.0 #398

Closed

30 tasks

luke-jr reviewed Nov 8, 2018

View reviewed changes

src/init.cpp Outdated Show resolved Hide resolved

luke-jr reviewed Nov 8, 2018

View reviewed changes

src/init.cpp Outdated Show resolved Hide resolved

luke-jr reviewed Nov 8, 2018

View reviewed changes

src/init.cpp Outdated Show resolved Hide resolved

luke-jr reviewed Nov 8, 2018

View reviewed changes

src/chainparams.cpp Outdated Show resolved Hide resolved

stevenroose force-pushed the e17-pegins branch 2 times, most recently from 60307e0 to d345979 Compare November 15, 2018 17:23

luke-jr reviewed Nov 15, 2018

View reviewed changes

src/primitives/transaction.h Show resolved Hide resolved

instagibbs reviewed Nov 16, 2018

View reviewed changes

src/primitives/transaction.h Outdated Show resolved Hide resolved

stevenroose force-pushed the e17-pegins branch from ec032ab to 1ee34ff Compare November 21, 2018 21:31

stevenroose mentioned this pull request Nov 26, 2018

tests: Support calling add_nodes more than once bitcoin/bitcoin#14805

Merged

stevenroose force-pushed the e17-pegins branch 2 times, most recently from f2d87aa to 2a46806 Compare December 13, 2018 13:51

stevenroose force-pushed the e17-pegins branch 2 times, most recently from 181edea to b69eb3b Compare December 14, 2018 16:26

instagibbs reviewed Dec 14, 2018

View reviewed changes

src/pegins.cpp Outdated Show resolved Hide resolved

stevenroose force-pushed the e17-pegins branch from b69eb3b to 1bee32c Compare December 14, 2018 16:57

instagibbs reviewed Dec 14, 2018

View reviewed changes

src/pegins.cpp Outdated Show resolved Hide resolved

instagibbs reviewed Dec 14, 2018

View reviewed changes

src/wallet/rpcwallet.cpp Outdated Show resolved Hide resolved

instagibbs reviewed Dec 14, 2018

View reviewed changes

stevenroose added 11 commits January 2, 2019 16:12

Add mainchain rpc client

d39d440

Add parent address encoding

18ee341

Add support for NullData addresses (OP_RETURN)

ac1eadd

Add pegin input serialization

ae54d4a

Skip normal validation of pegin inputs

89613b8

Special validation added in next commits.

Serialize parent blocks without pegin flags

037b260

Add pegin validation utility methods

fb8a453

Add getsidechaininfo rpc

d6686b6

Add tweakfedpegscript rpc

2db1f2b

Add "vdata" field to createrawtransaction rpc

22ec499

Change CCoinsMapKey to use chain-aware outpoints

0d07d21

stevenroose force-pushed the e17-pegins branch from d74433d to 034c642 Compare January 2, 2019 15:28

instagibbs reviewed Jan 2, 2019

View reviewed changes

src/txdb.cpp Show resolved Hide resolved

src/txdb.cpp Show resolved Hide resolved

src/txdb.cpp Outdated Show resolved Hide resolved

src/txdb.cpp Show resolved Hide resolved

stevenroose force-pushed the e17-pegins branch from aee6880 to d358364 Compare January 2, 2019 17:43

stevenroose added 8 commits January 2, 2019 18:46

Add spentness flag to pegin coins

f4adb46

Validation of pegin inputs

5cbb014

Add pegin validation unit tests

0e4e834

Add periodic RPC recheck and invalid block recheck

4688e3e

Recognize pegout scripts

7bb9380

Add pegin and pegout RPC calls

b56f7da

Add support for signed-blocks parent chains

d888540

Integration test for pegins and pegouts

d358364

instagibbs merged commit d358364 into ElementsProject:elements-0.17 Jan 2, 2019

stevenroose deleted the e17-pegins branch March 25, 2019 14:12

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[0.17] Add pegin validation #458

[0.17] Add pegin validation #458

stevenroose commented Nov 7, 2018

stevenroose commented Nov 26, 2018

instagibbs commented Nov 26, 2018

stevenroose commented Nov 27, 2018

instagibbs commented Dec 14, 2018

instagibbs commented Dec 14, 2018

instagibbs Dec 14, 2018

stevenroose Dec 17, 2018

stevenroose commented Dec 17, 2018

instagibbs commented Jan 2, 2019

instagibbs commented Jan 2, 2019

[0.17] Add pegin validation #458

[0.17] Add pegin validation #458

Conversation

stevenroose commented Nov 7, 2018

stevenroose commented Nov 26, 2018

instagibbs commented Nov 26, 2018

stevenroose commented Nov 27, 2018

instagibbs commented Dec 14, 2018

instagibbs commented Dec 14, 2018

instagibbs Dec 14, 2018

Choose a reason for hiding this comment

stevenroose Dec 17, 2018

Choose a reason for hiding this comment

stevenroose commented Dec 17, 2018

instagibbs commented Jan 2, 2019

instagibbs commented Jan 2, 2019