QA: feature_fedpeg.py: Remove re-implementation of sync_all #421
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(redundant and inferior)
1 task
Contributor
|
Oh I wasn't aware that there was a tACK 9b030c1 |
Contributor
|
ACK 9b030c1 |
instagibbs
added a commit
that referenced
this pull request
Sep 27, 2018
9b030c1 QA: feature_fedpeg.py: Remove re-implementation of sync_all (Jorge Timón)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...which is redundant and inferior to the one in the test framework.
We needed to re-implement it to avoid pegging.py depending on the freamework, but we don't need it anymore.