Skip to content

Conversation

@instagibbs
Copy link
Contributor

No description provided.

@jtimon
Copy link
Contributor

jtimon commented Jun 5, 2018

utACK e8d416c

@instagibbs instagibbs merged commit e8d416c into ElementsProject:elements-0.14.1 Jun 6, 2018
instagibbs added a commit that referenced this pull request Jun 6, 2018
e8d416c allow all other base58 prefix things to be set by conf file (Gregory Sanders)
gwillen pushed a commit that referenced this pull request Jun 1, 2022
…-sort Peers table

986bf78 qt: Emit dataChanged signal to dynamically re-sort Peers table (Hennadii Stepanov)

Pull request description:

  [By default](https://doc.qt.io/qt-5/qsortfilterproxymodel.html#details), the `PeerTableSortProxy`
  > dynamically re-sorts ... data whenever the original model changes.

  That is not the case on master (8cdf917) as in ecbd911 (#164) no signals are emitted to notify about model changes.

  This PR uses a dedicated [`dataChanged`](https://doc.qt.io/qt-5/qabstractitemmodel.html#dataChanged) signal.

  Fixes #367.

  An alternative to #374.

ACKs for top commit:
  jarolrod:
    ACK 986bf78

Tree-SHA512: dcb92c2f9a2c632880429e9528007db426d2ad938c64dfa1f1538c03e4b62620df52ad7daf33b582976c67b472ff76bc0dae707049f4bbbd4941232cee9ce3d4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants