-
Notifications
You must be signed in to change notification settings - Fork 377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inconsistent naming in the application #667
Comments
The Elements Core vs Liquid is I think as we intend it to be. "Elements Core" is the software, "Liquid" is the network. So But the mentions of the Bitcoin blockchain are an issue. We traverse the code often for mentions of Bitcoin, and we often let one slip here or there. Translation files make that task a whole lot harder still. |
There's plenty of unhandles Bitcoin name mentions and it would be quite intensive to go over all of them:
It might be worth it to go over all those within strings. |
5e30195 Add parameter for chain name in initial download string (Philippe McLean) f5aa08f Replace some Bitcoin mentions with Elements (Steven Roose) Pull request description: Solves #667. Tree-SHA512: fdee9fe38cfef9946bd2672f6f13317f5ebc6874b16bb87027e39130fe8d46e7cd04d6cb01ea1d1e203188be93ecdf8b027a81344f033a15e40c586cd485d140
Liquid Core
for first time, dialog sayswelcome to Elements Core
, and tells me that it will download and store a copy of theBitcoin block chain
- pretty sure this is referring to Liquid blockchain - this is obviously very confusing. Liquid is not even mentioned.Bitcoin blockchain
is 1GB big, containing transaction data from 2009 - specific naming of blockchain size seems risky if not dynamically generated, will go out of date quick.I was downloading Liquid binaries, so expected to see application called Liquid Core, and dialog reference to the Liquid block chain (sidechain).
Version: liquid-0.17.0-osx-unsigned.dmg
The text was updated successfully, but these errors were encountered: