Merge #959: Make it clear that the CRangeCheck is not called on expli…

…cit values

a8a1a93 Make it clear that the CRangeCheck is not called on explicit values (Steven Roose)

Pull request description:

  That is enforced by the `VerifyAmounts` method for regular transactions
  and by the `VerifyIssuanceAmounts` method for issuance values.

Tree-SHA512: 69064ca21dbe3a574f38ba8ea9a13cc2d4b6d0ac2b306fad59ff6fa92e63e08c8f4607da82c31731dcf91044eb47c8d79ced2ff49c7c0843343f438eb8bac943

src/confidential_validation.cpp

@@ -52,9 +52,7 @@ CAmountMap GetFeeMap(const CTransaction& tx) {
 }
 
 bool CRangeCheck::operator()() {
-    if (val->IsExplicit()) {
-        return true;
-    }
+    assert(val->IsCommitment());
 
     if (!CachingRangeProofChecker(store).VerifyRangeProof(rangeproof, val->vchCommitment, assetCommitment, scriptPubKey, secp256k1_ctx_verify_amounts)) {
         error = SCRIPT_ERR_RANGEPROOF;