Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

document development better #26

Merged
merged 2 commits into from
Oct 3, 2023
Merged

document development better #26

merged 2 commits into from
Oct 3, 2023

Conversation

philvarner
Copy link

No description provided.

MattBialas
MattBialas approved these changes Oct 3, 2023
View reviewed changes
Copy link
Collaborator

@MattBialas MattBialas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good – when you say "configure AWS credentials", do you mean just setting them via your CLI?

Or is that done by filling in the other 2 AWS_* values in the docker-compose.yml file?

@philvarner
Copy link
Author

The instructions aren't using the docker-compose file, so I suppose with that you have to explicitly set the AWS* env vars, but I haven't tried.

It doesn't matter how you set the credentials, any of the ways that boto3 can pick them up works.

@philvarner philvarner merged commit 67c7557 into main Oct 3, 2023
9 checks passed
@philvarner philvarner deleted the pv/document-development branch October 3, 2023 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MattBialas MattBialas MattBialas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@philvarner @MattBialas