Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resolve cross package dependency for theme-default #192

Merged
merged 1 commit into from
Sep 30, 2016
Merged

resolve cross package dependency for theme-default #192

merged 1 commit into from
Sep 30, 2016

Conversation

pi0
Copy link
Contributor

@pi0 pi0 commented Sep 29, 2016

popup.css in package theme-default depends on dialog package dependencies. vue-popup is already required in global context. so this PR removes this dependency :)

@QingWei-Li QingWei-Li merged commit 9ed735e into ElemeFE:master Sep 30, 2016
hazel54 pushed a commit to hazel54/element that referenced this pull request Aug 29, 2018
@Martin0809
Merge pull request ElemeFE#192 from e1emeb0t/dev
39c8c4d 
Publish
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pi0 @QingWei-Li