Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tabs: fix infinite loop call update when pane destroy #17380

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

a631807682
Copy link
Contributor

@a631807682 a631807682 commented Sep 9, 2019

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow Element's contributing guide (中文 | English | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer relative issues for you PR.

Issue

Close #16746
Related pr #14496

Desc

     const paneSlots = this.$slots.default.filter(vnode => vnode.tag &&
            vnode.componentOptions && vnode.componentOptions.Ctor.options.name === 'ElTabPane');

paneSlots matched componentInstance._isDestroyed instance, and then force update it, so it infinite loop call update.

add condition ... && !componentInstance._isDestroyed in the filter can fix it, but i do not think it is necessary to update all panes if one pane changed.

@element-bot
Copy link
Member

Deploy preview for element ready!

Built with commit 415b193

https://deploy-preview-17380--element.netlify.com

@a631807682 a631807682 changed the title fix: tabs infinite loop to update pane when patch fix: tabs infinite loop to update pane between pane destory and tabs destory Sep 9, 2019
@a631807682 a631807682 changed the title fix: tabs infinite loop to update pane between pane destory and tabs destory fix: tabs infinite loop to update pane Sep 9, 2019
@a631807682 a631807682 changed the title fix: tabs infinite loop to update pane Tabs: fix infinite loop call update when pane destroy Sep 9, 2019
@poncianodiego
Copy link

Can this one be merged?

@enguerrand-dilitrust
Copy link

@cs1707 Can you have a look and merge this one please ?

@enguerrand-dilitrust
Copy link

@cs1707 Can you have a look and merge this one please ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants