Skip to content

Added the missing "customClass" option to the message-box component #894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 12, 2018
Merged

Added the missing "customClass" option to the message-box component #894

merged 4 commits into from
Dec 12, 2018

Conversation

Adpearance
Copy link
Contributor

@Adpearance Adpearance commented Dec 11, 2018 •
edited
Loading

  • Make sure you are merging your commits to master branch.
  • Add some descriptions and refer relative issues for you PR.
  • Rebase your commits to make your pull request meaningful.
  • Make sure that your changes pass npm test, npm run lint and npm run build.

Changes in this pull request

  • Added the missing "customClass" to the message-box component. The documentation for MessageBox shows the availability for a customClass option, however the code does not. We have added the option back in and attached it to the component wrapper for use.
  • https://elemefe.github.io/element-react/#/en-US/message-box

hazel54
hazel54 approved these changes Dec 12, 2018
View reviewed changes
Copy link
Contributor

@hazel54 hazel54 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hazel54 hazel54 merged commit f7742a2 into ElemeFE:master Dec 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hazel54 hazel54 hazel54 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Adpearance @hazel54