sets the irght extension when downloading from url

src/FileDownloaders/FileDownloader.php

@@ -2,6 +2,7 @@
 
 namespace Elegantly\Media\FileDownloaders;
 
+use Elegantly\Media\Helpers\File;
 use Exception;
 use Spatie\TemporaryDirectory\TemporaryDirectory;
 
@@ -15,7 +16,7 @@ public static function getTemporaryFile(string $url, ?TemporaryDirectory $tempor
             ],
         ]);
 
-        if (! $stream = @fopen($url, 'r', false, $context)) {
+        if (!$stream = @fopen($url, 'r', false, $context)) {
             throw new Exception("Can't reach the url: {$url}");
         }
 
@@ -30,6 +31,15 @@ public static function getTemporaryFile(string $url, ?TemporaryDirectory $tempor
 
         fclose($stream);
 
+
+        if ($extension = File::extension($path)) {
+            $pathWithExtension = "{$path}.{$extension}";
+
+            rename($path, $pathWithExtension);
+
+            return $pathWithExtension;
+        }
+
         return $path;
     }
 }

src/Helpers/File.php

@@ -50,7 +50,7 @@ public static function extension(string|HttpFile|UploadedFile $file): ?string
             return $file->guessExtension() ?? $file->getExtension();
         }
 
-        return SupportFile::extension($file);
+        return SupportFile::extension($file) ?: SupportFile::guessExtension($file);
     }
 
     public static function type(string $path): MediaType

tests/Unit/FileDownloaderTest.php

@@ -17,3 +17,22 @@
 
     expect(is_file($path))->toBe(false);
 });
+
+it('download a file from an url as a temporary file and sets the right extension', function () {
+
+    $temporaryDirectory = (new TemporaryDirectory)
+        ->location(storage_path('media-tmp'))
+        ->create();
+
+    $path = FileDownloader::getTemporaryFile(
+        "https://icon.horse/icon/discord.com",
+        $temporaryDirectory
+    );
+
+    expect(is_file($path))->toBe(true);
+    expect(str($path)->endsWith(".png"))->toBe(true);
+
+    $temporaryDirectory->delete();
+
+    expect(is_file($path))->toBe(false);
+});