Skip to content

Support for .NET 6 #636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 6, 2022
Merged

Support for .NET 6 #636

merged 5 commits into from
Apr 6, 2022

Conversation

danatcofo
Copy link
Contributor

  • NET 6 Support
  • Target a specific project in the electronize build/start command using /dotnet-project <projectName>.csproj

NOTE: the .NET6 runtime has targeted System.Drawing.Common at windows architectures and will cause warnings. This should be addressed at some time.

https://docs.microsoft.com/en-us/dotnet/core/compatibility/core-libraries/6.0/system-drawing-common-windows-only

Also included is the ability to target a specific project in the `electronize build/start` command using /dotnet-project
@danatcofo
Copy link
Contributor Author

appveyor is failing on net6 not being supported... looking into that.

@danatcofo
Copy link
Contributor Author

Updated the appveyor to run a dedicated script appveyor.cmd and removed the 'custom' runs on that script due to lack of support for win7/single file build on the Visual Studio 2022 image.

removing the full path reference as suggested.

Co-authored-by: alborozd <alborozd@gmail.com>
@danatcofo danatcofo mentioned this pull request Dec 31, 2021
@robalexclark
Copy link

Does anyone know if this can the merged into main?

@danatcofo
Copy link
Contributor Author

I have this and most of the other PRs merged in a fork branch. Working fine for me there.

@GregorBiswanger
Copy link
Member

The next big update is coming soon!

@MutatedGamer
Copy link

MutatedGamer commented Feb 4, 2022

I tried out a local build of the source branch for this PR and noticed a quirk:

If I specify a aspCoreBackendPort in my manifest, I am unable to connect to the ASP.NET Core server. electronize start logs Now listening on: http://localhost:<myport>, but navigating to that URL gives a 404.

Interestingly, if I start with electronize start /watch, I am navigate to http://localhost:<myport> and get properly redirected to my SpaProxyServerUrl.

I wonder if this is related: dotnet/aspnetcore#38185


Actually I was wrong 😄. At the same time I added the custom port, I removed

app.UseSpa(spa => ...);

from my program.cs, thinking it was un-needed with the new .csproj SPA settings. Guess I was wrong!

@danatcofo
Copy link
Contributor Author

Yah I didn't implement that functionality into the change set. I haven't even figured out or researched how to do that yet.

@GregorBiswanger GregorBiswanger merged commit 7222c9e into ElectronNET:master Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants