-
-
Notifications
You must be signed in to change notification settings - Fork 737
Switch to async socket lib #595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
GregorBiswanger
merged 74 commits into
ElectronNET:master
from
theolivenbaum:switch-to-new-socket-lib
Apr 6, 2022
Merged
Switch to async socket lib #595
GregorBiswanger
merged 74 commits into
ElectronNET:master
from
theolivenbaum:switch-to-new-socket-lib
Apr 6, 2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[skip ci]
Remove deprecated socket lib
This reverts commit be41cae.
GregorBiswanger
approved these changes
Apr 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@GregorBiswanger finally had some time to prepare a PR with my changes:
Quick summary of what changed:
On(triggerEvent, () => { ... })
Would probably be good if you do a quick review of the TS changes, I had originally only changed the JS side, then noticed you were using typescript for generating it :)
Closes #431