Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Need the ability to pass msbuild properties through the electronize command. #523

Closed
DelpireNI opened this issue Jan 8, 2021 · 0 comments · Fixed by #531
Closed

Need the ability to pass msbuild properties through the electronize command. #523

DelpireNI opened this issue Jan 8, 2021 · 0 comments · Fixed by #531
Labels
Feature

Comments

@DelpireNI
Copy link

One of the things we are doing is using CI/CD to set the assembly and file versions of our binaries/application. dotnet publish allows you to pass any msbuild variables you want via -p:=
https://docs.microsoft.com/en-us/dotnet/core/tools/dotnet-publish

It would be really nice if we could pass /dotnet-msbuild-properties or something into the electronize command when we build so that we can set any msbuild properties we would like.
danatcofo added a commit to stackify/Electron.NET that referenced this issue Jan 25, 2021
@danatcofo
Pass dotnet publsh /p: arguments to the publish command
dd5bfd3 
use '/p:propertyName=value' or '/property:propertyName=value' to pass in dotnet build property overrides.

fixes ElectronNET#523
ElectronNET#523
@danatcofo danatcofo mentioned this issue Jan 25, 2021
Merged
GregorBiswanger added a commit that referenced this issue Jul 1, 2021
@GregorBiswanger
Merge pull request #531 from stackify/issue/523
3cdff74 
fixes #523 allow for property overrides to be passed in
phantomdev99 pushed a commit to phantomdev99/Electron--.NET that referenced this issue Mar 7, 2023
Pass dotnet publsh /p: arguments to the publish command
076ce98 
use '/p:propertyName=value' or '/property:propertyName=value' to pass in dotnet build property overrides.

fixes #523
ElectronNET/Electron.NET#523
sendevman pushed a commit to sendevman/Electron.NET that referenced this issue Sep 1, 2024
@danatcofo
Pass dotnet publsh /p: arguments to the publish command
ed8ac0a 
use '/p:propertyName=value' or '/property:propertyName=value' to pass in dotnet build property overrides.

fixes #523
ElectronNET/Electron.NET#523
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fixes #523 allow for property overrides to be passed in stackify/Electron.NET
1 participant
@DelpireNI