Skip to content

♻️ Migrate CLI print methods to single module #601

@keithrfung

Description

@keithrfung

Is there an existing issue for this?

  • I have searched the existing issues

Suggestion

To improve the CLI and be a bit more pythonic, migrate the common click to echo to a more aptly named module. Ideally, this should contain the references to click.echo to a single module, but the closest to this is best.

Possible Implementation

Create a print_utils.py file in the electionguard_cli to be used for all print functionality. These should all be methods and no classes should be necessary. This should allow the deletion of e2estepbase.py

Suggested items to migrate:
https://github.com/microsoft/electionguard-python/blob/03698c683ab35f608e35dc9b66217caa1d40f7eb/src/electionguard_cli/e2e_steps/input_retrieval_step.py#L42
https://github.com/microsoft/electionguard-python/blob/03698c683ab35f608e35dc9b66217caa1d40f7eb/src/electionguard_cli/e2e_steps/e2e_step_base.py#L14
https://github.com/microsoft/electionguard-python/blob/03698c683ab35f608e35dc9b66217caa1d40f7eb/src/electionguard_cli/e2e_steps/e2e_step_base.py#L19

https://github.com/microsoft/electionguard-python/blob/03698c683ab35f608e35dc9b66217caa1d40f7eb/src/electionguard_cli/e2e_steps/print_results_step.py#L13

Anything else?

No response

Metadata

Metadata

Labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions