Open
Conversation
Possibly not functional yet. Heavily based on pccr's python implementation.
Got advice from RabidTech's Rob and Mermop.
Understood the concept of self.<function> and fixed things. Works.
Owner
|
Can you just write some tests to verify that it works, and consistently works correctly? You can create a "ruby" folder, and move this file into that and write the test file there as well. |
Author
|
Hey pcragone, thanks for the feedback. I'm working my way through the issues and improving it a bit slowly. :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Used advice on how to Ruby from RabidTech's Merube. This functions. :)