Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#11: Init Config #37

Merged
merged 13 commits into from
Dec 27, 2023
Merged

#11: Init Config #37

merged 13 commits into from
Dec 27, 2023

Conversation

roma-glushko
Copy link
Member

@roma-glushko roma-glushko commented Dec 24, 2023

This PR inits Glide Config system and propagates the config info wherever it's needed.

The PR implements GEP0001:

Usage

glide --config ./config.dev.yaml

Changes

  • added a config package with config provider that returns the actual config to use
  • added a new CLI flag to set config path
  • config content is processed to expand $ENVAR, ${env:ENVAR}, ${file:/path/to/file} directives
  • defined default configs in the corresponding parts of the gateway
  • added a new Secret field to wrap sensitive data

Follow-Ups:

@roma-glushko roma-glushko self-assigned this Dec 24, 2023
@roma-glushko roma-glushko linked an issue Dec 24, 2023 that may be closed by this pull request
@roma-glushko roma-glushko marked this pull request as draft December 24, 2023 13:40
@roma-glushko roma-glushko marked this pull request as ready for review December 26, 2023 21:42
pkg/cmd/cli.go Outdated
Use: "",
Version: pkg.GetVersion(),
Use: "glide",
Short: "🐦Glide is an open source lightweight high-performant model gateway",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spelling: "🐦Glide is an open-source, lightweight, high-performance model gateway."

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Applied in 85afa75

@roma-glushko roma-glushko merged commit 6e363e5 into develop Dec 27, 2023
5 checks passed
@roma-glushko roma-glushko deleted the 11-init-configs branch December 27, 2023 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Init configs
2 participants