Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix some errors #298

Merged
merged 3 commits into from
Mar 18, 2024
Merged

fix some errors #298

merged 3 commits into from
Mar 18, 2024

Conversation

xpzouying
Copy link
Contributor

@xpzouying xpzouying commented Mar 17, 2024 •
edited
Loading

  • check error twice
  • handle replace flag when init logger

@xpzouying
rm unnecessary code
2dca73f 
* check error twice
@xpzouying
log: handle replace flag when init logger
e7e402e 
replace global logger when replaceGlobal is true.
@xpzouying xpzouying changed the title rm unnecessary code fix some errors Mar 17, 2024
Ehco1996
Ehco1996 approved these changes Mar 18, 2024
View reviewed changes
Copy link
Owner

@Ehco1996 Ehco1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Ehco1996 Ehco1996 merged commit 719ff86 into Ehco1996:master Mar 18, 2024
1 check passed
@BrewTestBot BrewTestBot mentioned this pull request Jun 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ehco1996 Ehco1996 Ehco1996 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xpzouying @Ehco1996