Merge pull request #2 from EficodeDemoOrg/feature/copilot-autofix

Feature/copilot autofix.

Rautasta kamaa. Timanttia.

Author: EficodeRjpalt

.github/workflows/ci-with-codeql.yml

@@ -0,0 +1,54 @@
+# This workflow uses GitHub's CodeQL to analyze your Java code for vulnerabilities and errors.
+
+name: "CI with CodeQL"
+
+on:
+  push:
+    branches: [ main ]
+  pull_request:
+    branches: [ main ]
+  schedule:
+    - cron: '0 0 * * 0'
+
+jobs:
+  analyze-and-ci:
+    runs-on: ubuntu-latest
+    permissions:
+      actions: read
+      contents: read
+      packages: read
+      security-events: write
+
+    strategy:
+      fail-fast: false
+      matrix:
+        language: [ 'java' ]
+
+    steps:
+      - name: Checkout repository
+        uses: actions/checkout@v4
+
+      - name: Initialize CodeQL
+        uses: github/codeql-action/init@v3
+        with:
+          languages: ${{ matrix.language }}
+
+      - name: Set up JDK 11
+        uses: actions/setup-java@v4
+        with:
+          distribution: 'temurin'
+          java-version: '11'
+
+      - name: Build with Maven
+        run: mvn -B clean package
+
+      - name: Run Checkstyle (Lint)
+        run: mvn checkstyle:check
+
+      - name: Run Tests
+        run: mvn test
+
+      - name: Perform CodeQL Analysis
+        uses: github/codeql-action/analyze@v3
+        with:
+          category: "/language:${{matrix.language}}"

checkstyle.xml

@@ -0,0 +1,28 @@
+<?xml version="1.0"?>
+<!DOCTYPE module PUBLIC
+    "-//Checkstyle//DTD Checkstyle Configuration 1.3//EN"
+    "https://checkstyle.org/dtds/configuration_1_3.dtd">
+
+<module name="Checker">
+    <module name="LineLength">
+        <property name="max" value="120"/>
+    </module>
+    <module name="FileTabCharacter">
+        <property name="eachLine" value="true"/>
+    </module>
+    <module name="TreeWalker">
+        <module name="Indentation">
+            <property name="basicOffset" value="4"/>
+            <property name="tabWidth" value="4"/>
+        </module>
+        <module name="NeedBraces"/>
+        <module name="JavadocMethod"/>
+        <module name="JavadocType"/>
+        <module name="LocalVariableName"/>
+        <module name="MethodName"/>
+        <module name="ParameterName"/>
+        <module name="MemberName"/>
+        <module name="ConstantName"/>
+        <module name="PackageName"/>
+    </module>
+</module>

pom.xml

@@ -151,6 +151,27 @@
                     </execution>
                 </executions>
             </plugin>
+            <!-- Checkstyle plugin for code style enforcement -->
+            <plugin>
+                <groupId>org.apache.maven.plugins</groupId>
+                <artifactId>maven-checkstyle-plugin</artifactId>
+                <version>3.3.1</version>
+                <configuration>
+                    <configLocation>checkstyle.xml</configLocation>
+                    <consoleOutput>true</consoleOutput>
+                    <failsOnError>true</failsOnError>
+                    <linkXRef>false</linkXRef>
+                </configuration>
+                <executions>
+                    <execution>
+                        <id>validate</id>
+                        <phase>validate</phase>
+                        <goals>
+                            <goal>check</goal>
+                        </goals>
+                    </execution>
+                </executions>
+            </plugin>
         </plugins>
     </build>
 </project>

src/main/java/com/weather/app/OpenWeatherMapClient.java

@@ -59,14 +59,17 @@ public WeatherData getWeatherFromApi(String city) throws WeatherApiException {
         String trimmedCity = city.trim();
         if (!VALID_CITY_PATTERN.matcher(trimmedCity).matches()) {
             LOGGER.log(Level.WARNING, "Invalid city name format: {0}", trimmedCity);
-            throw new WeatherApiException("Invalid city name format. City names should only contain letters, numbers, spaces, hyphens, and periods");
+            throw new WeatherApiException(
+                    "Invalid city name format. City names should only contain letters, numbers, " +
+                    "spaces, hyphens, and periods");
         }
 
         LOGGER.log(Level.FINE, "Fetching weather for city: {0}", trimmedCity);
 
         try {
             String url = buildApiUrl(trimmedCity);
-            LOGGER.log(Level.FINE, "API request URL: {0}", url.replaceAll("appid=[^&]+", "appid=REDACTED"));
+            LOGGER.log(Level.FINE, "API request URL: {0}",
+                    url.replaceAll("appid=[^&]+", "appid=REDACTED"));
             HttpRequest request = HttpRequest.newBuilder()
                     .uri(new URI(url))
                     .GET()

src/main/java/com/weather/app/WeatherApp.java

@@ -88,7 +88,8 @@ public static void main(String[] args) {
 
         } catch (ConfigUtil.ConfigException e) {
             LOGGER.log(Level.SEVERE, "Configuration error: " + e.getMessage(), e);
-            LOGGER.log(Level.SEVERE, "Please set the OPENWEATHERMAP_API_KEY environment variable or add api.key to config.properties");
+            LOGGER.log(Level.SEVERE,
+                    "Please set the OPENWEATHERMAP_API_KEY environment variable or add api.key to config.properties");
             exit(1);
         } catch (WeatherApiException e) {
             LOGGER.log(Level.SEVERE, "Error fetching weather data: " + e.getMessage(), e);