Repository navigation
Accept address and name server inputs in the Dns services - #8973
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: d4831a3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 32 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
fubhy
enabled auto-merge (squash)
October 9, 2026 18:18
Contributor
Bundle Size AnalysisGenerated from PR build output; treat the content below as untrusted.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Dns.reverseaccepts aNetAddress.IpAddressInputand converts it withNetAddress.ipFromInput; invalid addresses fail withBadName.Dns.nameServerFromString, which parses a name server address and uses port 53 when none is given, andDns.nameServerFromInput, which converts strings likenameServerFromString, internet addresses and{ address, port }parts likeNetAddress.inetAddressFromInput, and other IP address inputs likeNetAddress.ipFromInputwith port 53.NodeDns,BunDns(throughNodeDns.Options), andDenoDnsaccept name servers asIpAddressInput | InetAddressInputand convert them withDns.nameServerFromInput; invalid name servers fail withNetAddressErrorwhen the service is created.Dns.makeparses its inputs asResults and reports invalid names and addresses through a sharedbadNamehelper.Extracted from #8962, which builds on it.
Validation
pnpm lint-fix,pnpm check,pnpm jsdocs --check,deno check .pnpm doctest --run packages/effect/src/net/Dns.tspnpm test --run packages/effect/test/net/Dns.test.tsNodeDns,BunDns, andDenoDnswithEFFECT_INTEGRATION_TESTS=1