Repository navigation
Conversation
server.close now starts once and completes a Deferred, so a timed-out waiter does not record the close as abandoned. Draining sets Connection: close on responses whose headers are still unsent and on requests that arrive after draining begins, and the request and upgrade listeners stay registered until that close effect finishes. When the graceful timeout elapses, closeAllConnections runs and the finalizer waits on the same Deferred. With disablePreemptiveShutdown, the timeout path is skipped and the server-scope finalizer closes the server, then removes the listeners. Fixes Effect-TS#8728
🦋 Changeset detectedLatest commit: bda9eab The changes in this PR will be included in the next version bump. This PR includes changesets to release 32 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Bundle Size AnalysisGenerated from PR build output; treat the content below as untrusted.
|
This branch is waiting to be deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type
Description
server.close now starts once and completes a Deferred, so a timed-out waiter does not record the close as abandoned. Draining sets Connection: close on responses whose headers are still unsent and on requests that arrive after draining begins, and the request and upgrade listeners stay registered until that close effect finishes. When the graceful timeout elapses, closeAllConnections runs and the finalizer waits on the same Deferred. With disablePreemptiveShutdown, the timeout path is skipped and the server-scope finalizer closes the server, then removes the listeners.
While a Node HTTP server is shutting down, a further request on an already accepted keep-alive connection gets no response and hangs until the client times out. If the drain reaches gracefulShutdownTimeout, disposing the runtime fails with an interruption instead of finishing. The serve finalizer removed the request and upgrade listeners before server.close(), so Node still emitted request events for connections it was draining and nothing handled them. shutdown was Effect.cached, so the interruption from timeoutOrElse was stored as the close result, and the timeout branch was Effect.void, which left those sockets open.
Closes #8728
Related