Repository navigation
Type received and forwarded HTTP request methods as open strings - #8766
Merged
tim-smart merged 4 commits intoOct 6, 2026
Merged
Conversation
HttpServerRequest.fromWeb, HttpClientRequest.fromWeb and HttpServerRequest.toClientRequest preserve arbitrary method tokens such as PROPFIND, but cast them to the closed HttpMethod union. Widen the received/forwarded method properties to string, keep HttpMethod for the known convenience constructors, and add a non-narrowing string overload to HttpMethod.hasBody. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: cba5f03 The changes in this PR will be included in the next version bump. This PR includes changesets to release 32 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Bundle Size AnalysisGenerated from PR build output; treat the content below as untrusted.
|
effect-bot
pushed a commit
that referenced
this pull request
Oct 6, 2026
Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Co-authored-by: Tim Smart <hello@timsmart.co>
effect-bot
pushed a commit
that referenced
this pull request
Oct 6, 2026
Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Co-authored-by: Tim Smart <hello@timsmart.co>
effect-bot
pushed a commit
that referenced
this pull request
Oct 6, 2026
Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Co-authored-by: Tim Smart <hello@timsmart.co>
effect-bot
pushed a commit
that referenced
this pull request
Oct 6, 2026
Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Co-authored-by: Tim Smart <hello@timsmart.co>
effect-bot
pushed a commit
that referenced
this pull request
Oct 6, 2026
Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Co-authored-by: Tim Smart <hello@timsmart.co>
effect-bot
pushed a commit
that referenced
this pull request
Oct 6, 2026
Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Co-authored-by: Tim Smart <hello@timsmart.co>
effect-bot
pushed a commit
that referenced
this pull request
Oct 6, 2026
Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Co-authored-by: Tim Smart <hello@timsmart.co>
effect-bot
pushed a commit
that referenced
this pull request
Oct 6, 2026
Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Co-authored-by: Tim Smart <hello@timsmart.co>
effect-bot
pushed a commit
that referenced
this pull request
Oct 6, 2026
Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Co-authored-by: Tim Smart <hello@timsmart.co>
effect-bot
pushed a commit
that referenced
this pull request
Oct 6, 2026
Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Co-authored-by: Tim Smart <hello@timsmart.co>
effect-bot
pushed a commit
that referenced
this pull request
Oct 6, 2026
Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Co-authored-by: Tim Smart <hello@timsmart.co>
effect-bot
pushed a commit
that referenced
this pull request
Oct 6, 2026
Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Co-authored-by: Tim Smart <hello@timsmart.co>
Closed
effect-bot
pushed a commit
that referenced
this pull request
Oct 6, 2026
Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Co-authored-by: Tim Smart <hello@timsmart.co>
effect-bot
pushed a commit
that referenced
this pull request
Oct 6, 2026
Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Co-authored-by: Tim Smart <hello@timsmart.co>
effect-bot
pushed a commit
that referenced
this pull request
Oct 6, 2026
Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Co-authored-by: Tim Smart <hello@timsmart.co>
effect-bot
pushed a commit
that referenced
this pull request
Oct 6, 2026
Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Co-authored-by: Tim Smart <hello@timsmart.co>
effect-bot
pushed a commit
that referenced
this pull request
Oct 6, 2026
Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Co-authored-by: Tim Smart <hello@timsmart.co>
effect-bot
pushed a commit
that referenced
this pull request
Oct 6, 2026
Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Co-authored-by: Tim Smart <hello@timsmart.co>
effect-bot
pushed a commit
that referenced
this pull request
Oct 6, 2026
Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Co-authored-by: Tim Smart <hello@timsmart.co>
effect-bot
pushed a commit
that referenced
this pull request
Oct 6, 2026
Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Co-authored-by: Tim Smart <hello@timsmart.co>
effect-bot
pushed a commit
that referenced
this pull request
Oct 6, 2026
Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Co-authored-by: Tim Smart <hello@timsmart.co>
effect-bot
pushed a commit
that referenced
this pull request
Oct 6, 2026
Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Co-authored-by: Tim Smart <hello@timsmart.co>
effect-bot
pushed a commit
that referenced
this pull request
Oct 6, 2026
Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Co-authored-by: Tim Smart <hello@timsmart.co>
effect-bot
pushed a commit
that referenced
this pull request
Oct 6, 2026
Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Co-authored-by: Tim Smart <hello@timsmart.co>
effect-bot
pushed a commit
that referenced
this pull request
Oct 6, 2026
Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Co-authored-by: Tim Smart <hello@timsmart.co>
effect-bot
pushed a commit
that referenced
this pull request
Oct 6, 2026
Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Co-authored-by: Tim Smart <hello@timsmart.co>
effect-bot
pushed a commit
that referenced
this pull request
Oct 6, 2026
Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Co-authored-by: Tim Smart <hello@timsmart.co>
effect-bot
pushed a commit
that referenced
this pull request
Oct 6, 2026
Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Co-authored-by: Tim Smart <hello@timsmart.co>
effect-bot
pushed a commit
that referenced
this pull request
Oct 6, 2026
Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Co-authored-by: Tim Smart <hello@timsmart.co>
effect-bot
pushed a commit
that referenced
this pull request
Oct 6, 2026
Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Co-authored-by: Tim Smart <hello@timsmart.co>
effect-bot
pushed a commit
that referenced
this pull request
Oct 6, 2026
Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Co-authored-by: Tim Smart <hello@timsmart.co>
effect-bot
pushed a commit
that referenced
this pull request
Oct 6, 2026
Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Co-authored-by: Tim Smart <hello@timsmart.co>
effect-bot
pushed a commit
that referenced
this pull request
Oct 6, 2026
Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Co-authored-by: Tim Smart <hello@timsmart.co>
effect-bot
pushed a commit
that referenced
this pull request
Oct 6, 2026
Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Co-authored-by: Tim Smart <hello@timsmart.co>
effect-bot
pushed a commit
that referenced
this pull request
Oct 6, 2026
Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Co-authored-by: Tim Smart <hello@timsmart.co>
effect-bot
pushed a commit
that referenced
this pull request
Oct 6, 2026
Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Co-authored-by: Tim Smart <hello@timsmart.co>
effect-bot
pushed a commit
that referenced
this pull request
Oct 6, 2026
Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Co-authored-by: Tim Smart <hello@timsmart.co>
effect-bot
pushed a commit
that referenced
this pull request
Oct 6, 2026
Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Co-authored-by: Tim Smart <hello@timsmart.co>
effect-bot
pushed a commit
that referenced
this pull request
Oct 6, 2026
Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Co-authored-by: Tim Smart <hello@timsmart.co>
effect-bot
pushed a commit
that referenced
this pull request
Oct 6, 2026
Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Co-authored-by: Tim Smart <hello@timsmart.co>
effect-bot
pushed a commit
that referenced
this pull request
Oct 6, 2026
Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Co-authored-by: Tim Smart <hello@timsmart.co>
effect-bot
pushed a commit
that referenced
this pull request
Oct 6, 2026
Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Co-authored-by: Tim Smart <hello@timsmart.co>
effect-bot
pushed a commit
that referenced
this pull request
Oct 6, 2026
Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Co-authored-by: Tim Smart <hello@timsmart.co>
effect-bot
pushed a commit
that referenced
this pull request
Oct 7, 2026
Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Co-authored-by: Tim Smart <hello@timsmart.co>
effect-bot
pushed a commit
that referenced
this pull request
Oct 7, 2026
Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Co-authored-by: Tim Smart <hello@timsmart.co>
effect-bot
pushed a commit
that referenced
this pull request
Oct 7, 2026
Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Co-authored-by: Tim Smart <hello@timsmart.co>
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Native and forwarded requests can carry methods such as
PROPFIND, butHttpServerRequest.methodandHttpClientRequest.methodwere typed as the closedHttpMethodunion. Exhaustive matches could therefore miss values that occur at runtime.Fix
HttpClientRequest.makeWith, asstring. Keep route and convenience-constructor methods restricted toHttpMethod.HttpMethod.hasBodyaccept strings without narrowing unknown methods to the known-method union. Preserve the type predicate forHttpMethodarguments and the existing runtime body policy.AiError.HttpRequestDetails.methodtoSchema.Stringso forwarded extension methods can be encoded and decoded. Existing known-method payloads remain valid.HttpServerRequest.test.tsandHttpClientRequest.test.tssuites, including type equality and server-client-server forwarding.This changes the public request method types, not method normalization or forwarding behavior. Consumers that exhaustively match request methods need a fallback or
HttpMethod.isHttpMethod. The changeset is minor for this type-level compatibility change.Validation
nix develop -c pnpm checknix develop -c pnpm linthasBodypolicy and HTTP request-details schema round-trips for all known methods andPROPFIND.git diff --checkCloses EFF-1718