Repository navigation
Conversation
… kill A non-exec'ing shell leader can exit before descendants, so scoped release and kill now await the Node close event instead of the leader exit.
🦋 Changeset detectedLatest commit: cf9902a The changes in this PR will be included in the next version bump. This PR includes changesets to release 30 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Bundle Size AnalysisGenerated from PR build output; treat the content below as untrusted.
|
6 tasks done
Contributor
|
Already fixed on main |
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NodeChildProcessSpawneralready signals the process group on scoped release andkill, but it waited on the leader'sexit. On Linux,shell: trueuses dash (sh -c), which does notexecthe command. SIGTERM kills the shell immediately,exitfires,forceKillAfteris dropped, and descendants keep running.Release and
killnow wait for the Nodecloseevent (inherited stdio released). PublicexitCode/isRunningstill useexit.Fixes #7821
Test plan
vitest --run packages/platform/node-shared/test/NodeChildProcessSpawner.test.tsshell: truescope close does not return until the wrapper and its inherited-stdio child have printed*:SIGTERMexitCode/isRunningremain bound to the leaderexitevent