Acknowledge misunderstanding of review request #5901
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No code changes were made. This PR already contains the fix for
HttpServerRequest.toWebthrowingTypeError: duplex option is required when sending a bodyin Node.js.The previous comment requested a code review of this PR, which I misunderstood as a request to open a new PR. This response acknowledges that error.
Current Implementation
The fix adds the
duplex: "half"option when constructing aRequestwith a streaming body:This fix is already present in the codebase at
packages/platform/src/HttpServerRequest.ts:245-251.💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.