-
-
Notifications
You must be signed in to change notification settings - Fork 446
Refactor AiModel and remove AiPlan
#4918
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 5da36c5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
tim-smart
reviewed
May 24, 2025
2212e0f to
05cd1a9
Compare
59ef614 to
7d8c110
Compare
ffbe642 to
21e4d2e
Compare
Co-authored-by: Tim <hello@timsmart.co>
Co-authored-by: Tim <hello@timsmart.co>
Co-authored-by: Tim <hello@timsmart.co>
Co-authored-by: Tim <hello@timsmart.co>
Co-authored-by: Sebastian Lorenz <fubhy@fubhy.com>
Contributor
|
/rebase |
178bdd6 to
18ae1f9
Compare
Co-authored-by: Tim <hello@timsmart.co>
18ae1f9 to
5da36c5
Compare
tim-smart
approved these changes
May 27, 2025
Merged
effect-bot
pushed a commit
that referenced
this pull request
May 27, 2025
Co-authored-by: Maxim Khramtsov <khraks.mamtsov@gmail.com> Co-authored-by: Tim <hello@timsmart.co> Co-authored-by: Vincent François <vincent.francois@inato.com> Co-authored-by: Chris Wilkinson <chris@prereview.org> Co-authored-by: Tylor Steinberger <tlsteinberger167@gmail.com> Co-authored-by: Jason Rudder <indxxxd@gmail.com> Co-authored-by: Sebastian Lorenz <fubhy@fubhy.com>
effect-bot
pushed a commit
that referenced
this pull request
May 27, 2025
Co-authored-by: Maxim Khramtsov <khraks.mamtsov@gmail.com> Co-authored-by: Tim <hello@timsmart.co> Co-authored-by: Vincent François <vincent.francois@inato.com> Co-authored-by: Chris Wilkinson <chris@prereview.org> Co-authored-by: Tylor Steinberger <tlsteinberger167@gmail.com> Co-authored-by: Jason Rudder <indxxxd@gmail.com> Co-authored-by: Sebastian Lorenz <fubhy@fubhy.com>
tim-smart
added a commit
that referenced
this pull request
May 27, 2025
Co-authored-by: Maxim Khramtsov <khraks.mamtsov@gmail.com> Co-authored-by: Tim <hello@timsmart.co> Co-authored-by: Vincent François <vincent.francois@inato.com> Co-authored-by: Chris Wilkinson <chris@prereview.org> Co-authored-by: Tylor Steinberger <tlsteinberger167@gmail.com> Co-authored-by: Jason Rudder <indxxxd@gmail.com> Co-authored-by: Sebastian Lorenz <fubhy@fubhy.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type
Description
Warning
This PR will depend on merge of #4910 to replace
AiPlan.The goal of this PR is to simplify the usage of
AiModels in bothEffectandStreamprograms by leveraging well-known patterns in Effect for requiring and providing services. The ergonomics ofAiModelhave been substantially improved - anAiModelnow returns a plainLayerwhich can be used to provide services to a program that makes use of large language model interactions.Before
After
In addition,
AiModelcan beyield*'ed to produce a layer with no requirements.This shifts the requirements of building the layer into the calling effect, which is particularly useful for creating AI-powered services.
Related