-
-
Notifications
You must be signed in to change notification settings - Fork 455
Add Effect.transposeMapOption #4597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Effect.transposeMapOption #4597
Conversation
🦋 Changeset detectedLatest commit: 31acdef The changes in this PR will be included in the next version bump. This PR includes changesets to release 36 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
I would go with |
I completely agree with your points so I pushed a new commit to use that naming :) And nice catch on the documentation example, sorry for that! It's now fixed! |
Type
Description
Add
Effect.traverseOption. Today in our codebase we're using a helper to do that, but I really think it would be a nice addition that would be useful to others.I'm aware that we could use the
Effect.transposeOption:But this is simpler and more relevant for all the use cases where I need it in my work:
So I'd still push for this addition, hence my move to try to open a PR for it! :)
For the naming of this method, in our codebase we used
optionTraverseEffectbut given the discussions in issue #3142, it seems that adding this method in the Effect module and using the termtraversewould be the way to go.Also, if you agree with this addition and have ideas on improving the documentation part of this feature I'm interested as I'm not fully happy with my final version.
Related