Skip to content

Conversation

@tim-smart
Copy link
Contributor

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Feb 17, 2025

🦋 Changeset detected

Latest commit: b629c90

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 36 packages
Name Type
@effect/opentelemetry Major
effect Minor
@effect/cli Major
@effect/cluster-browser Major
@effect/cluster-node Major
@effect/cluster-workflow Major
@effect/cluster Major
@effect/experimental Major
@effect/platform-browser Major
@effect/platform-bun Major
@effect/platform-node-shared Major
@effect/platform-node Major
@effect/platform Major
@effect/printer-ansi Major
@effect/printer Major
@effect/rpc-http Major
@effect/rpc Major
@effect/sql-clickhouse Major
@effect/sql-d1 Major
@effect/sql-drizzle Major
@effect/sql-kysely Major
@effect/sql-libsql Major
@effect/sql-mssql Major
@effect/sql-mysql2 Major
@effect/sql-pg Major
@effect/sql-sqlite-bun Major
@effect/sql-sqlite-do Major
@effect/sql-sqlite-node Major
@effect/sql-sqlite-react-native Major
@effect/sql-sqlite-wasm Major
@effect/sql Major
@effect/typeclass Major
@effect/vitest Major
@effect/ai Major
@effect/ai-anthropic Major
@effect/ai-openai Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@effect-bot effect-bot changed the base branch from main to next-minor February 17, 2025 01:14
@effect-bot effect-bot force-pushed the next-minor branch 4 times, most recently from 1be5dbd to 4ec16d6 Compare February 18, 2025 16:48
@mikearnaldi
Copy link
Member

mikearnaldi commented Feb 18, 2025

maybe Effect.spanAddLink(), or even Effect.link()

@tim-smart
Copy link
Contributor Author

maybe Effect.spanAddLink(), or even Effect.link()

We already have:

  • Effect.linkSpan
  • Effect.annotateSpan
  • Effect.annotateCurrentSpan

So we just need an api for linking to the current span (not regional)

Effect.linkCurrentSpan or Effect.linkToCurrentSpan were some options.

@mikearnaldi
Copy link
Member

  • Effect.linkSpan

we don't have Effect.linkSpan we have Effect.linkSpans, we will need to re-think naming in 4.0 as it's very unclear from the name what Effect.linkSpans does, probably something like Effect.addLinkToChildSpans or similar

@effect-bot effect-bot force-pushed the next-minor branch 16 times, most recently from deb4c54 to 00518f3 Compare February 25, 2025 10:08
@tim-smart tim-smart merged commit f98c1c4 into next-minor Mar 10, 2025
11 checks passed
@tim-smart tim-smart deleted the span-links branch March 10, 2025 21:30
@github-project-automation github-project-automation bot moved this from Discussion Ongoing to Done in PR Backlog Mar 10, 2025
@effect-bot effect-bot mentioned this pull request Mar 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants