remove generics from HttpClient tag service (#4169)

Effect-TS · Dec 22, 2024 · ef64c6f · ef64c6f
1 parent e1eeb2d
commit ef64c6f
Show file tree

Hide file tree

Showing 4 changed files with 190 additions and 172 deletions.
diff --git a/.changeset/friendly-kiwis-end.md b/.changeset/friendly-kiwis-end.md
@@ -0,0 +1,8 @@
+---
+"@effect/platform": minor
+---
+
+remove generics from HttpClient tag service
+
+Instead you can now use `HttpClient.With<E, R>` to specify the error and
+requirement types.
diff --git a/packages/platform/dtslint/HttpApiClient.ts b/packages/platform/dtslint/HttpApiClient.ts
@@ -83,7 +83,7 @@ Effect.gen(function*() {
   const clientEndpointEffect = HttpApiClient.endpoint(TestApi, "Group1", "EndpointA")
   // $ExpectType never
   type _clientEndpointEffectError = Effect.Effect.Error<typeof clientEndpointEffect>
-  // $ExpectType "ApiErrorR" | "Group1ErrorR" | "EndpointAErrorR" | "EndpointASuccessR" | "EndpointASecurityErrorR" | "Group1SecurityErrorR" | "ApiSecurityErrorR" | HttpClient<HttpClientError, Scope>
+  // $ExpectType "ApiErrorR" | "Group1ErrorR" | "EndpointAErrorR" | "EndpointASuccessR" | "EndpointASecurityErrorR" | "Group1SecurityErrorR" | "ApiSecurityErrorR" | HttpClient
   type _clientEndpointEffectContext = Effect.Effect.Context<typeof clientEndpointEffect>
 
   const clientEndpoint = yield* clientEndpointEffect
@@ -100,7 +100,7 @@ Effect.gen(function*() {
   const clientGroupEffect = HttpApiClient.group(TestApi, "Group1")
   // $ExpectType never
   type _clientGroupEffectError = Effect.Effect.Error<typeof clientGroupEffect>
-  // $ExpectType "ApiErrorR" | "Group1ErrorR" | "EndpointAErrorR" | "EndpointASuccessR" | "EndpointBErrorR" | "EndpointBSuccessR" | "EndpointASecurityErrorR" | "EndpointBSecurityErrorR" | "Group1SecurityErrorR" | "ApiSecurityErrorR" | HttpClient<HttpClientError, Scope>
+  // $ExpectType "ApiErrorR" | "Group1ErrorR" | "EndpointAErrorR" | "EndpointASuccessR" | "EndpointBErrorR" | "EndpointBSuccessR" | "EndpointASecurityErrorR" | "EndpointBSecurityErrorR" | "Group1SecurityErrorR" | "ApiSecurityErrorR" | HttpClient
   type _clientGroupEffectContext = Effect.Effect.Context<typeof clientGroupEffect>
 
   const clientGroup = yield* clientGroupEffect
@@ -117,7 +117,7 @@ Effect.gen(function*() {
   const clientApiEffect = HttpApiClient.make(TestApi)
   // $ExpectType never
   type _clientApiEffectError = Effect.Effect.Error<typeof clientApiEffect>
-  // $ExpectType "ApiErrorR" | "Group1ErrorR" | "EndpointAErrorR" | "EndpointASuccessR" | "EndpointBErrorR" | "EndpointBSuccessR" | "EndpointASecurityErrorR" | "EndpointBSecurityErrorR" | "Group1SecurityErrorR" | "ApiSecurityErrorR" | "Group2ErrorR" | "EndpointCErrorR" | "EndpointCSuccessR" | HttpClient<HttpClientError, Scope>
+  // $ExpectType "ApiErrorR" | "Group1ErrorR" | "EndpointAErrorR" | "EndpointASuccessR" | "EndpointBErrorR" | "EndpointBSuccessR" | "EndpointASecurityErrorR" | "EndpointBSecurityErrorR" | "Group1SecurityErrorR" | "ApiSecurityErrorR" | "Group2ErrorR" | "EndpointCErrorR" | "EndpointCSuccessR" | HttpClient
   type _clientApiEffectContext = Effect.Effect.Context<typeof clientApiEffect>
 
   const clientApi = yield* clientApiEffect