feat: Simplify CASE WHEN true THEN expr to expr #1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds an optimization rule to simplify CASE expressions where the first condition is always true (literal
true), reducing them to just the THEN expression.This fixes the issue where expressions like:
CASE WHEN true THEN 1 ELSE x ENDwere not being simplified to just
1.Changes
expr_simplifier.rsthat detectsCASE WHEN true THEN exprpatternsTest Plan
Before/After
Before:
After:
Fixes apache#17448