Refactor Windows Utilities & Improve Brotli Performance #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darkstorm2150
changed the title
Edw590
reviewed
Oct 16, 2024
Utils/WindowsSpecifics.go
Outdated
| * Checks if the program is running with Administrator (root) privileges. | ||
| * | ||
| * @return true if running as admin, false otherwise | ||
| */ |
There was a problem hiding this comment.
Just a thing. Could you leave it with the documentation "format" I had? And on line 84+ too? I have it like that on purpose. If you click Ctrl+Q on GoLand with the cursor on the documentation, the documentation appears properly formatted. First I had as you put, but I noticed GoLand doesn't properly format it, so I changed the format to the one I use.
There was a problem hiding this comment.
I understand, I will make changes needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes two commits that enhance the codebase in different areas:
1. Refactor Windows Utilities: Enhanced Security & Code Readability
RunningAsAdminPROCESSESfor secure Administrator privilege checks.GenerateCtrlCPROCESSESfunction to prevent potential security vulnerabilities.2. Improve Brotli Performance
Affected Files:
Utils/windows_utilities.go(refactored)Utils/UtilsDeCompression.go(performance improvements)