Skip to content

Fix disk space error during multi-firmware extraction with debug mode #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
Copilot wants to merge 6 commits into
base: sixteen
Choose a base branch
from
Draft

Fix disk space error during multi-firmware extraction with debug mode #5

Copilot wants to merge 6 commits into from

Conversation

Copy link

Copilot AI commented Dec 29, 2025 •
edited
Loading

The firmware extraction fails with "Error 70 : Write error : cannot write decoded block" when unpacking SM-S938B after SM-S916B. The main firmware extraction consumes 6-8GB, leaving insufficient space for lz4 to decompress the next firmware's super.img (requires 3GB for streaming: 1-2GB compressed input + 1-2GB decompression buffer).

Changes

Debug Infrastructure

  • Added LOG_DEBUG function that outputs when DEBUG_BUILD=true (enabled via --debug flag)
  • Added debug logging at key extraction points: container contents, disk space checks, extraction operations

Disk Space Management

  • Check 3GB availability before lz4 decompression in FETCH_FILE
  • Automatic cleanup on low space: remove tmp_* files owned by current user only
  • Between-firmware cleanup after each extraction (main → extra → stock)

Error Detection

  • Pattern match lz4-specific errors: Error [0-9]+ : Write error
  • Report available disk space when write errors occur

Implementation

# Before lz4 decompression
if ! CHECK_DISK_SPACE "$out_dir" 3; then
    # Safe cleanup: only script-created temp files, current user only
    find /tmp -type f -name "tmp_*" -user "$(whoami)" -delete
    find "$out_dir" -type f -name "tmp_*" -delete
    
    # Recheck after cleanup
    CHECK_DISK_SPACE "$out_dir" 3 || return 1
fi

The cleanup is conservative: never uses rm -rf /tmp/*, only removes files matching tmp_* pattern owned by current user, with 5-minute age threshold for /tmp to protect concurrent operations.

Original prompt

Acgiba rl modo debug y corrije /runner/work/AstroROM/AstroROM/firmware/downloaded/tmp_download/SM-S938B_EUX
[DONE] Successfully downloaded and installed EXTRA firmware (S938BXXS7BYKS/S938BOXM7BYKS/S938BXXS7BYKS)
[DONE] Firmware downloads complete.
Checking main firmware..
[16:26:48] [INFO] Unpacking SM-S916B firmware..
[16:27:34] [*] Converting sparse image... �\�|�/�-�\�|�/�-�\�|�/�-�\�|�/�-�\�|�/�-�\�|�/�-�\�|�/�-�\�|�/�-�\�|�/�-�\�|�/�-�\�|�/�-�\�|�/�-�\�|�/�-�\�|�/�-�\�|�/�-�\�|�/�-�\�|�/�-�\�|�/�-�\�|�
Attempting to extract partition 'vendor'...
Dealing with extent 0 from target source 0...
Attempting to extract partition 'system_ext'...
Dealing with extent 0 from target source 0...
Attempting to extract partition 'system_dlkm'...
Dealing with extent 0 from target source 0...
Attempting to extract partition 'product'...
Dealing with extent 0 from target source 0...
Attempting to extract partition 'odm'...
Dealing with extent 0 from target source 0...
Attempting to extract partition 'vendor_dlkm'...
Dealing with extent 0 from target source 0...
Attempting to extract partition 'system'...
Dealing with extent 0 from target source 0...
[DONE] Partitions unpacked
[16:29:19] [INFO] Extracting system
[16:30:03] [INFO] Extracting links, modes & attrs from system
[16:30:49] [INFO] Extracting product
[16:31:05] [INFO] Extracting links, modes & attrs from product
[16:31:07] [INFO] Extracting system_ext
[16:31:10] [INFO] Extracting links, modes & attrs from system_ext
[16:31:17] [INFO] Extracting odm
[16:31:17] [INFO] Extracting links, modes & attrs from odm
[16:31:17] [INFO] Extracting vendor_dlkm
[16:31:17] [INFO] Extracting links, modes & attrs from vendor_dlkm
[16:31:20] [INFO] Extracting system_dlkm
[16:31:20] [INFO] Extracting links, modes & attrs from system_dlkm
[16:31:20] [INFO] Extracting vendor
[16:31:57] [INFO] Extracting links, modes & attrs from vendor
[DONE] Unpacked SM-S916B firmware. ( Got 7 partitions)
Checking extra firmware..
[16:32:20] [INFO] Unpacking SM-S938B firmware..
Error 70 : Write error : cannot write decoded block

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI and others added 5 commits December 29, 2025 16:40
@Eduardob3677
Add disk space checks and cleanup for firmware extraction
8887fbe 
- Add disk space check before lz4 decompression in FETCH_FILE
- Add cleanup of temporary files between firmware extractions
- Add LOG_ERROR function for better error reporting
- Add debug logging to track disk usage during extraction

Co-authored-by: Eduardob3677 <212653915+Eduardob3677@users.noreply.github.com>
@Eduardob3677
Enable debug mode and add debug logging for firmware extraction
3180dbf 
- Add LOG_DEBUG function that respects DEBUG_BUILD flag
- Add extensive debug logging in FETCH_FILE to track extraction steps
- Add debug logging in EXTRACT_FIRMWARE to track firmware processing
- Debug logs show disk space checks, cleanup attempts, and extraction progress
- Helps diagnose "Error 70: Write error" during lz4 decompression

Co-authored-by: Eduardob3677 <212653915+Eduardob3677@users.noreply.github.com>
@Eduardob3677
Fix code review issues: safer cleanup and correct grep regex
4c056a2 
- Replace dangerous 'rm -rf /tmp/*' with targeted cleanup of only script-created files
- Use '-user $(whoami)' to only delete files owned by current user
- Fix grep regex pattern to use -E flag with proper alternation syntax
- Improves safety and correctness of disk space cleanup operations

Co-authored-by: Eduardob3677 <212653915+Eduardob3677@users.noreply.github.com>
@Eduardob3677
Add detailed comments and improve error detection pattern
c09f0ea 
- Add detailed comments explaining 3GB disk space requirement for lz4
- Add comment explaining 5 minute threshold for temp file cleanup
- Improve grep pattern to specifically match lz4 Error format
- Pattern now matches "Error 70 : Write error" and similar lz4 errors more precisely

Co-authored-by: Eduardob3677 <212653915+Eduardob3677@users.noreply.github.com>
@Eduardob3677
Final code review fixes: complete documentation and safety improvements
e5353cb 
- Add comment distinguishing LOG_ERROR (non-fatal) from ERROR_EXIT (fatal)
- Add -user filter to /tmp cleanup in unpack_fw.sh for consistency and safety
- Clarify 3GB disk space requirement with detailed explanation of streaming decompression
- Improve grep pattern to match exact lz4 error format "Error N : Write error"
- All magic numbers and thresholds now fully documented

Co-authored-by: Eduardob3677 <212653915+Eduardob3677@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix firmware download and extraction errors Fix disk space error during multi-firmware extraction with debug mode Dec 29, 2025
Copilot AI requested a review from Eduardob3677 December 29, 2025 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Eduardob3677 Eduardob3677 Awaiting requested review from Eduardob3677

Assignees

Copilot code review Copilot

@Eduardob3677 Eduardob3677

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Eduardob3677